Bug 364695 - git master 2016-06-24 - Small compiler warning..
Summary: git master 2016-06-24 - Small compiler warning..
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-24 08:52 UTC by Evert Vorster
Modified: 2016-06-24 18:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2016-06-24 08:52:06 UTC
Gcc 6 comes with warnings when indentation is misleading in code. While the code is working properly, this might cause a bug later, as the code is not doing what the indentation suggests:


[ 76%] Building CXX object src/CMakeFiles/kdenlive.dir/monitor/recmanager.cpp.o
[ 76%] Building CXX object src/CMakeFiles/kdenlive.dir/monitor/recmonitor.cpp.o
/tmp/yaourt-tmp-evert/aur-kdenlive-git/src/kdenlive/src/monitor/recmonitor.cpp: In member function ‘void RecMonitor::slotRecord()’:
/tmp/yaourt-tmp-evert/aur-kdenlive-git/src/kdenlive/src/monitor/recmonitor.cpp:725:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
         if (!KdenliveSettings::grab_parameters().simplified().isEmpty())
         ^~
/tmp/yaourt-tmp-evert/aur-kdenlive-git/src/kdenlive/src/monitor/recmonitor.cpp:727:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
      m_captureArgs << path;
      ^~~~~~~~~~~~~
[ 76%] Building CXX object src/CMakeFiles/kdenlive.dir/monitor/smallruler.cpp.o


Reproducible: Always
Comment 1 Jean-Baptiste Mardelle 2016-06-24 18:08:36 UTC
Git commit 22c1d50d7c2579639f937aa88d7bafd86e7efac0 by Jean-Baptiste Mardelle.
Committed on 24/06/2016 at 15:31.
Pushed by mardelle into branch 'master'.

Fix compilation warning

M  +4    -3    src/monitor/recmonitor.cpp

http://commits.kde.org/kdenlive/22c1d50d7c2579639f937aa88d7bafd86e7efac0
Comment 2 Evert Vorster 2016-06-24 18:25:17 UTC
Fixed, Thank you.