Bug 364615 - after mass rename, ctrl+z (undo) should revert ALL folders/files names
Summary: after mass rename, ctrl+z (undo) should revert ALL folders/files names
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 17.12.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-21 21:37 UTC by Patrick Silva
Modified: 2018-04-21 09:48 UTC (History)
2 users (show)

See Also:
Latest Commit: https://cgit.kde.org/dolphin.git/commit/?id=c5eb4e31161ccf422a2f2492fe998c5c9817bea4
Version Fixed In: 18.03.80
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2016-06-21 21:37:06 UTC 
Currently only ONE file/folder name is reverted.

Reproducible: Always

Steps to Reproduce:
1. select two or more folders/files
2. press F2 to mass rename and apply a new name to the files/folders
3. press ctrl+z to undo mass rename process

Actual Results:  
Only ONE folder/file name is reverted.

Expected Results:  
I think the correct behavior is revert ALL folder/file names.
If the user renames hundreds or thousands of folders/files to any wrong name a third app is required to revert all wrong names.
Comment 1 Patrick Silva 2017-06-18 14:48:48 UTC 
Any progress with this issue?
Comment 2 Kai Uwe Broulik 2017-06-20 09:59:18 UTC 
The way mass-rename is currently implemented is by spwaning a gazillion rename jobs (one for each file), so as far as KIO and KUndoManager is concerned, each task is separate. This also caused funny bugs where it would spawn hundrets of progress notifications. There needs to be a dedicated mass rename KCompositeJob that does all of this right.
Comment 3 Patrick Silva 2018-04-19 15:58:57 UTC 
Solved in Dolphin 18.04. \o/