Thank you for commit to Bug 357642 but I have two following requests. I have just checked in KDE Neon 5.6.95. Please make calendar show holidays in main window, where now I have info "No events for today". http://i.imgur.com/JwqPnbB.png as it was in Plasma 4 http://i.imgur.com/YnFbIU1.jpg Not everyone, at least home users use korganizer, and even if so, not on every day events are planned. I usually will have this space empty with the above info "No events for today". I wish when user switches from one month to the next month holidays of that particular month are shown in a text form, as in KDE4. This is important when users make plans. In different countries different holidays are important. The way it was in KDE 4 seems to me more convenient, because it allowed quickly switch thorough the months and find the holiday we were looking for. Not sure if this should be separate bug report (if you wish I will report) but holidays are not visible with other desktop themes then Breeze. I think it should be independent from desktop theme settings. http://i.imgur.com/8AHFLtu.png http://i.imgur.com/wIsnWyc.png In general it is a rather bad practice to make things work with only default theme because mostly users are not capable to adjust other themes that are available on kde-look and authors of those themes not update theme promptly or at all. Not that I don't like changes but I must say that in KDE 4 it was perfect, beauty and functional. Don't take my comments as criticism, I just look at it from the point of view I use it. Reproducible: Always
I actually found it pretty terrible in Plasma 4 that it would randomly show events and holidays from the upcoming days. I'll let usability team decide.
> Not sure if this should be separate bug report It always should. > but holidays are not visible with other desktop themes then Breeze. I think it should be independent from desktop theme settings. It is independent. The mark on the calendar grid is new addition to the theme, the other themes simply need an update. > In general it is a rather bad practice to make things work with only default theme because mostly users are not capable to adjust other themes that are available on kde-look and authors of those themes not update theme promptly or at all. At the same time, we cannot limit ourselves forever because other theme creators don't react/are slow to react, that is not our fault and cannot be our fault. What is our fault, however, is that we should have communicated early that there will be new important addition in the Breeze theme and that authors should update their themes.
I thought (and expected) it would use the one from Breeze as a last resort
@Martin Looks like I made a bad judgement. What you have already noticed is bad communication issue. I think it would be good if developers when introducing changes that affect themes would update https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails and announce it in a bug itself and in other channels like https://dot.kde.org/ and planet kde. At the moment looking at the above guidelines from techbase I have no idea how to modify theme to take into account new elements.
> I thought (and expected) it would use the one from Breeze as a last resort Apparently not :/
*** Bug 365154 has been marked as a duplicate of this bug. ***
Or - better yet - user should be warned that the theme he is using does not support all the KDE features. Is it somehow possible? You will never be able to force all the theme authors to update them in time - as we could observe, even themes supplied with KDE may lack some of them...
Missing elements should fallback to the default theme, that is Breeze. Which it doesn't. So there's a bug.
What we need is better communication to theme creators that certain changes are happening and they need to add bits to their themes like in this case a tiny marker with the correct naming.
related wish for showing holydays in main windows - https://bugs.kde.org/show_bug.cgi?id=383634
*** This bug has been marked as a duplicate of bug 383634 ***