Bug 364462 - git master: off by frame when adding clip zones ending on final clip frame to the project bin
Summary: git master: off by frame when adding clip zones ending on final clip frame to...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-18 15:23 UTC by Wegwerf
Modified: 2016-06-20 16:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-06-18 15:23:58 UTC
Take a "slideshow" clip that consists of exactly 24+1 frame images and that has been rendered out from an animation tool. Add this to your project. Now, you want to add two zones from this clip to your project bin: frames 0-11 (inclusive), and frames 12-23 (inclusive).

Setting in point to 0 and out point to 0:0:0:11 is no problem: Ctrl-I adds a zone that's 12 frames long, as set.

Next, set the in point to 0:0:0:12 and out to 0:0:0:23. Ctrl-I now adds a zone that's only *11* frames in size. Check by dragging the zone from the *project bin* into the timeline. Also check in the project XML file: first clipzone is 0;12, while second clipzone is only 12;23 instead of 12;24.

In contrast, when you directly drag the 12 frames zone from the *clip monitor* into the timeline, the resulting clip will be 12 frames long, as set using the in and out point.

Looks like some off-by-one issue with the out point near or at the end of a clip. I remember having discussed that before in the context of advanced editing functions. So now we have a real-world example from a current project of mine where I need to set the out point correctly to the last frame.

Reproducible: Always
Comment 1 Jean-Baptiste Mardelle 2016-06-19 17:17:16 UTC
Git commit 93a7dc89241026a9788a7ed0838c80cff5fcad91 by Jean-Baptiste Mardelle.
Committed on 19/06/2016 at 16:48.
Pushed by mardelle into branch 'master'.

Fix one frame offset in clip monitor selection

M  +3    -11   src/monitor/monitor.cpp
M  +1    -2    src/renderer.cpp
M  +2    -2    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/93a7dc89241026a9788a7ed0838c80cff5fcad91
Comment 2 Wegwerf 2016-06-20 16:31:57 UTC
Looks okay to me, thank you very much for fixing this!