I'm using the automatic splitting audio from video feature. When I drag a clip onto the timeline, and audio exists on the first audio track, the splitted out audio should appear on the first open track. Right now it pops up over the audio already in the first audio track. Reproducible: Always Steps to Reproduce: 1. Put some audio clip on the first audio track. 2.Enable automatic audio split 3.Drag a video clip that also contains audio to above the audio clip added earlier. Actual Results: The splitted audio overlaps the audio already on the first audio track Expected Results: The splitted audio should appear on the next open audio track. If no track is available there should be an error message and the audio not split out. For extra bonus points, save this project, and load it up again. All the clips groups with audio on the same track will have the groupings lost, and the audio shifted. That is incredibly bad, too.
Git commit 3da2b6b2994a094164470bde0f71f465be0fb615 by Jean-Baptiste Mardelle. Committed on 16/06/2016 at 16:43. Pushed by mardelle into branch 'master'. First Randa commit: don't split audio over existing clip. If target audio track is not empty, abort audio split M +13 -7 src/timeline/customtrackview.cpp M +3 -2 src/timeline/customtrackview.h M +5 -3 src/timeline/timelinecommands.cpp M +2 -0 src/timeline/timelinecommands.h http://commits.kde.org/kdenlive/3da2b6b2994a094164470bde0f71f465be0fb615
This was not a bug. I tested it. When you work in "Strict mode" the audio splitted is always inserted in the audio track you set as target. If you let the target on the audio track 1 and you are in overwrite mode you'll achieve the situation described by Evert Vorster. Now, after the "fix" (abort the audio split) we done a step backward in the fine tuning the second editing modes also named "Strict mode". I suggest to revert back to the previous situation.
Created attachment 99536 [details] A sreen capture of the clip not extracting audio. Hmm.. .. how is it not a bug when you actually overlap audio on the same line? As soon as anything overlaps anywhere on the timeline, it starts corrupting the entire project. However, for me this is still not working proper, as it now aborts the split, even when there is an open audio track. Also, I give up, where do you enable "strict" mode, or set which track it is supposed to put the audio to? It should just put it on the first open audio track, right? I just went through the settings menu. -Evert-
Ah, the little green buttons on the tracks set the target. Also, when they are unset, there is no target, and then it takes the first open track. Great. Learn something every day! I guess when the target is enabled and it can't make the audio on that track, then aborting the audio split is the right thing to do, rather than overlapping the audio. I have lost quite a bit of work due to timeline corruption, and anything that avoids that is a step in the right direction. IMHO.
Ok, there is/was a combination of bug/regression. This is the expected behavior in auto split mode: 1 - If the target audio track is not empty, the audio will not be split. Target audio track has the green led and can be defined by clicking on the led or using shortcut (Shift+T) when track is selected. 2 - When in overwrite mode, the clip on audio target track should be replaced. I fixed issue 1 but it caused regression 2. Working on it
Git commit 1feba524895512b6025479409e42a667261673c3 by Jean-Baptiste Mardelle. Committed on 16/06/2016 at 18:27. Pushed by mardelle into branch 'master'. Fix split audio in overwrite mode M +3 -1 src/timeline/customtrackview.cpp http://commits.kde.org/kdenlive/1feba524895512b6025479409e42a667261673c3
I finally checked the fix you done and I think it's ok. I just believe that it's not correct, when in "strict mode" and in "normal mode", to disable the audio split feature. I think that to put the audio in the first free audio track is the correct way to behave. Same as if you split the audio in "mixed mode". If no audio tracks are free in "mixed mode" the split operation has to be disabled and in "Strict mode" you can't add both video and audio untill you have the empty tracks for both.
Thanks very much for this quick fix!