Bug 364350 - Warn users if saving fails because of a lack of disk space
Summary: Warn users if saving fails because of a lack of disk space
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 3.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-15 16:38 UTC by SylviaRitter
Modified: 2019-09-14 15:26 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SylviaRitter 2016-06-15 16:38:43 UTC
Hi. I can't save my Krita file :/. I get a list of lot of layers, which can't be saved. 
Is there something I can do? I don't won't to loose my current progress. 
Thanks!
Comment 1 SylviaRitter 2016-06-15 18:07:59 UTC
Now it crashed and I lost all the work that I did today :(. Autosave was on and I saved in between, but  it didn't work.
Comment 2 Halla Rempt 2016-06-15 21:06:31 UTC
Eek -- that sounds like you were trying to save as OpenEXR, and not as .kra?
Comment 3 SylviaRitter 2016-06-15 21:15:03 UTC
I save all my files as .kra or .psd. This time I wanted to save it as a .kra file. I didn't know what an OpenEXR file is %) and googled it. 
I also tried to save it under a different name, it didn't help. Another thought was that the "ä,ü,etc" in the layer comments could be a problem. 
Did this problem ever occurred before: "Failed to save the annotations for layer XYZ"?
Comment 4 Sven Langkamp 2016-06-15 21:38:57 UTC
The message only happens when something goes wrong with the saving of metadata for .kra files. Did you edit anything in Layer->Edit metadata... ?
Comment 5 SylviaRitter 2016-06-16 08:26:40 UTC
Hm, strange. I didn't edit anything in Layer -> Edit metadata.  I didn't know that this option exists.
Several layers were affected.
Comment 6 Halla Rempt 2016-06-16 08:44:32 UTC
Were some layers imported jpeg images? If so, could you share one of those images?
Comment 7 Halla Rempt 2016-06-16 08:46:08 UTC
In any case, it's probably not a good idea to block saving the pixel data on annotations or metadata -- though Sven isn't entirely correct: the annotation is the icc profile, not the metadata.
Comment 8 SylviaRitter 2016-06-16 10:29:47 UTC
Yes, some layers were imported jpeg images for color reference. Here is the .kra file:
https://www.dropbox.com/s/dkwi51x2pvh85hh/utopic_unicorn_d.kra.tar.bz2?dl=0
I hope it helps. As I've mentioned before in one of the previous bug reports, I create very high-res images for prints. Currently this is the highest resolution I work with.
Comment 9 Halla Rempt 2016-06-16 12:35:35 UTC
Could it be that you ran out of space on your temp drive? Krita first saves to a temporary location and then when saving worked, copies the file to the original place.
Comment 10 SylviaRitter 2016-06-16 13:09:56 UTC
Yes, that could be it. I'm currently always struggling with insufficient space. I bought two additional external hard drives to secure the final files twice.
Could Krita warn the user when this problem occurs? That would be very very helpful. 
Of course, Ubuntu warns me but that is sadly not enough. In that case I make space, the warnings stop, the painting absorbs me and then Krita crashes.
Comment 11 Halla Rempt 2016-06-16 16:16:53 UTC
Hm, we don't know how big an image will be in advance, so that's hardish -- but we could check after checking whether the write fails whether there's a space problem.
Comment 12 SylviaRitter 2016-06-16 18:41:47 UTC
Sounds good. It would help :).
Comment 13 Tiar 2019-08-29 18:35:42 UTC
Git commit 5f26933edb76bc8b1330a330d58db91953d02734 by Agata Cacko.
Committed on 29/08/2019 at 18:34.
Pushed by tymond into branch 'master'.

Fix jpeg crash Krita in case of any error

Before this commit, jpeg would crash if the user would try to save
the file into a location with not enough room for this file
or in any other cases that would cause an error.
This commit adds the simple error checking to the exporter, too,
since the importer already had it.

M  +213  -203  plugins/impex/jpeg/kis_jpeg_converter.cc

https://invent.kde.org/kde/krita/commit/5f26933edb76bc8b1330a330d58db91953d02734
Comment 14 Tiar 2019-09-02 12:51:20 UTC
Now all file formats show that the file couldn't be saved. The error message doesn't say anything about full partition though or lack of space. 

I'm gonna unassign myself from this report since now it's a wish request.
Comment 15 Tiar 2019-09-14 15:26:22 UTC
Git commit 6254079aa2eb92ab71212b71d07361283a1829e0 by Agata Cacko.
Committed on 14/09/2019 at 15:25.
Pushed by tymond into branch 'krita/4.2'.

Fix jpeg crash Krita in case of any error

Before this commit, jpeg would crash if the user would try to save
the file into a location with not enough room for this file
or in any other cases that would cause an error.
This commit adds the simple error checking to the exporter, too,
since the importer already had it.

M  +213  -203  plugins/impex/jpeg/kis_jpeg_converter.cc

https://invent.kde.org/kde/krita/commit/6254079aa2eb92ab71212b71d07361283a1829e0