Bug 364338 - Activity switcher calls in XQueryKeymap on wayland
Summary: Activity switcher calls in XQueryKeymap on wayland
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Activity Switcher sidebar (show other bugs)
Version: master
Platform: Other Linux
: NOR crash
Target Milestone: 1.0
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-15 06:49 UTC by Bhushan Shah
Modified: 2016-07-18 19:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bhushan Shah 2016-06-15 06:49:15 UTC
switcherbackend.cpp:61 have code copied from kwin's tabbox.cpp but it was never adopted to work on wayland, hence meta+tab crashes plasmashell on wayland.

Reproducible: Always
Comment 1 Ivan Čukić 2016-06-19 07:33:18 UTC
Martin mentioned (back in the days when the code was copied) that he is planning to add support for advanced shortcuts like these somewhere in kwin (iirc) so that applications like plasma can register them when 'wayland will solve it TM', and that is the reason why this was just a quick-and-dirty-copy implementation for the meta+tab feature.

CC-ing: Martin G.

p.s. For the time being, I would accept a patch that just disables this on wayland. I don't have a wayland setup, so it would be appreciated if someone who does deals with this.
Comment 2 Martin Flöser 2016-06-20 06:16:00 UTC
I cannot remember what I have said. Something like the Alt+Tab usage is something I cannot imagine to work properly outside of KWin on Wayland. I guess I was talking about KWin itself.

Concerning the fix: you don't need to have a Wayland setup to test. Just ensure that you don't call into X11 if you are not on platform X11. I communicated the required changes several times in the past.
Comment 3 Sebastian Kügler 2016-06-20 09:49:44 UTC
Ivan, as Wayland is on the list of our highest priorities as a team, I think an attitude of "I'd accept a patch for this" isn't enough. The team working on Wayland is already small for the task at hand, so we need individual maintainers to step in and fix their code when it's causing problems on Wayland. "I don't use it, so I don't care, you can fix it yourself" isn't exactly teamplay, and we need to be good team players to ever get a Wayland port stable. 

Please make sure your code works also on Wayland, it's important.
Comment 4 Ivan Čukić 2016-06-20 10:10:35 UTC
@martin

I can do that for now, but it means the feature will be broken until we find a way to do it via kwin.

@sebas

I'm sorry if I sounded like "i don't use it, I don't care". I was just asking for help since I have no idea how to handle this on wayland. And without wayland setup, issues like these slip up.

In the past, I missed to guard against  a few X-related things, and once even guarded something that Martin later said was not necessary (and the guards passed all other reviewers)
Comment 5 Ivan Čukić 2016-06-20 15:36:33 UTC
Can someone test https://phabricator.kde.org/D1963 whether this is ok?

p.s. Sebas, I'm not British, when I say "it would be appreciated" I actually mean that :)