Bug 364324 - git master 2016-06-14 Sub-grouping is not preserved
Summary: git master 2016-06-14 Sub-grouping is not preserved
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-06-14 16:47 UTC by Evert Vorster
Modified: 2018-09-27 06:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
showing grouping destroys sub-grouping (621.31 KB, video/quicktime)
2016-06-25 05:28 UTC, Evert Vorster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2016-06-14 16:47:52 UTC
Usually, when selecting a group of clips, one could drag it around. Now the selection instantly goes away when clicking and dragging anywhere in the selection. So, I thought, let's just put all these clips in a group and drag them around like that. 
Unfortunately, all my clips are little groups of video and corresponding audio clips, and when I removed the grouping of all the clips together, this sub-group was not preserved, so I was left with a mess of clips that were supposed to be little groups. 

Reproducible: Always

Steps to Reproduce:
1.Group a selection of groups on the timeline
2.Un-group the group

Actual Results:  
the origianal groupings were destroyed by the overall group

Expected Results:  
Groupings to be preserved through infinite levels of grouping.
Comment 1 Wegwerf 2016-06-14 17:41:19 UTC
Noticed the automatic unselection after a drag too ... this is really hindering my work flow. Hopefully, Jean-Baptiste can restore the previous behavior where selected clips got selected even after the mouse release from a mouse drag.
Comment 2 Jean-Baptiste Mardelle 2016-06-14 20:53:38 UTC
Git commit 5218c4fb900bf085b3bd0b7256a4d6184f01b5d8 by Jean-Baptiste Mardelle.
Committed on 14/06/2016 at 20:53.
Pushed by mardelle into branch 'master'.

Fix selection lost after move

M  +3    -3    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/5218c4fb900bf085b3bd0b7256a4d6184f01b5d8
Comment 3 Evert Vorster 2016-06-15 05:05:06 UTC
Thanks for fixing the selection going away on a drag. 

However, sub-groups are still not preserved. 
In an application like Inkscape, you can group groups, and when ungrouping, the original groupings are preserved. 

This would be a good thing to have in Kdenlive.
Comment 4 Evert Vorster 2016-06-25 05:28:31 UTC
Created attachment 99685 [details]
showing grouping destroys sub-grouping

Here is a clip showing that sub-grouping is destroyed.
Comment 5 Evert Vorster 2016-06-25 05:33:50 UTC
Hey JB, just added an example clip of sub-groups not being preserved through a grouping and ungrouping. 

This is a pretty serious bug, as suddenly there is more than twice the amount of work that needs to be done on a timeline. 

The groupings _must_ stay intact, or to put it differently, kdenlive has to support multiple levels of grouping smoothly.
I think I still have an open bug on not being able to apply a single effect to a group of clips. In my mind, when clips are grouped, they should act as one "virtual" clip. Then, when un-grouped, all the previous groupings must be preserved, as nested grouping is a feature of most other drawing packages.
Comment 6 Evert Vorster 2016-08-09 06:38:51 UTC
Still an issue for me, as of 2016-08-09

This makes the grouping functionality much less useful.
Grouping is supposed to make your life easier, not harder.
Comment 7 Andrew Crouthamel 2018-09-26 22:18:05 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Evert Vorster 2018-09-27 06:58:02 UTC
This seems fixed in the refactoring branch as od 2018-09-27

Thanks for the hard work, JB!