Bug 364297 - git master 2016-06-14 Clips dragged with spacer tool sometimes loses grouping
Summary: git master 2016-06-14 Clips dragged with spacer tool sometimes loses grouping
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
: 364735 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-06-14 07:23 UTC by Evert Vorster
Modified: 2016-07-06 03:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evert Vorster 2016-06-14 07:23:30 UTC
In my usual workflow, I select all the clips I want to work on, and drag them into the timeline. Then I edit the clips on the timeline for duration and position, effects and whatever else I feel. Then I press "m", and drag the rest of the clips closer, press "s" again and repeat the process. 
This way I am not constantly switching between clip monitor and project monitor, and also I don't have to look for the next clip, it's right there on the timeline. 

This used to work pretty well until the latest timeline refactoring. 

The worst bug I run into is that sometimes the grouping of audio clips are lost when I drag them with the spacer tool. Unfortunately it's hard to pinpoint, as another bug completely crashes gdb and the UI, and the only way I can get it back is to manually kill gdb, destroying the backtrace. 

Reproducible: Always

Steps to Reproduce:
1. Select and drag a hundred or so clips to the timeline (the problem seems worse with more clips)
2.resize first clip
3.select spacer tool, drag the rest of the clips closer. 
4. resize second clip, put it on a different line. 
5. drag the rest of the clips closer. 
6. Save project
7. revert to saved project.

Actual Results:  
The grouping between clips and their sound are lost in some occasions, but only the ones in the clips that were dragged with the spacer tool

Expected Results:  
Clips to retain their grouping through saves. 

I of course use automatic splitting of sound and video. 
When running kdenlive out of a terminal and watching the output, see and error:
"* ** Canot find clip to break: " And then some numbers, which I assume is frame and track number. 
I have not noticed this error before, and it might be related. On a different note, Cannot is spelled with two "n" in the middle. ;)
I also see other weirdness on the timeline still, for instance sometimes when I delete a clip the clip stays there, and I get a warning sound with no error message. When I then save and restore the clips positioning is messed up, sometimes, and almost always the grouping have been lost between video and audio clips.
Comment 1 Evert Vorster 2016-06-25 05:35:47 UTC
*** Bug 364735 has been marked as a duplicate of this bug. ***
Comment 2 Jean-Baptiste Mardelle 2016-06-25 06:53:37 UTC
Git commit 5798554e80e0fd9e327517862a4bb68e3b7210a3 by Jean-Baptiste Mardelle.
Committed on 25/06/2016 at 06:53.
Pushed by mardelle into branch 'master'.

Fix spacer timeline corruption
Related: bug 364585

M  +1    -2    src/timeline/customtrackview.cpp
M  +1    -1    src/timeline/managers/spacermanager.cpp

http://commits.kde.org/kdenlive/5798554e80e0fd9e327517862a4bb68e3b7210a3
Comment 3 Evert Vorster 2016-06-25 11:06:02 UTC
Fixed, thanks
Comment 4 farid 2016-07-05 21:52:58 UTC
please mark this as fixed.