Bug 364284 - Cannot edit “More...“ mount options - OK / Apply button missing
Summary: Cannot edit “More...“ mount options - OK / Apply button missing
Status: RESOLVED FIXED
Alias: None
Product: partitionmanager
Classification: Applications
Component: general (show other bugs)
Version: 2.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-13 23:28 UTC by lorenzo
Modified: 2016-06-15 17:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lorenzo 2016-06-13 23:28:38 UTC
There is no way to apply changes to “More...” mount options.

Reproducible: Always

Steps to Reproduce:
1. Start Partition Manager.
2. Select a partition with a mount point.
3. Right click and select “Unmount” to unmount it.
4. Right click and select "Edit Mount Point".
5. Click “More...” (I don't know how it is precisely labeled in English, I'm using the Italian translation which says “Altro...“. Anyway, it's the button supposed to allow the user to specify more mount options).


Actual Results:  
You can edit the mount options but there is no way to accept the changes. The only way to close the dialog is with the close window button which cancels the changes.

Expected Results:  
There should be an OK or Apply button in this dialog.

I'm using a fully updated Manjaro with Linux (x86_64) release 4.6.2-1-MANJARO.

Please note this is not a duplicate of bug 362207. This one is about the more mount options dialog, not the main Edit mount point dialog.

I would also suggest to tell the user how the mount options should be listed: one per row? Comma separated? Space separated?

Also, a complete list of general and filesystem-specific options (and their explanations) with checkboxes would be of great help.
Comment 1 Andrius Štikonas 2016-06-15 13:49:53 UTC
Git commit af140882a7a65c1d38869c2aff9f8ccb5fa95eb5 by Andrius Štikonas.
Committed on 15/06/2016 at 13:35.
Pushed by stikonas into branch 'master'.

Add Ok/Cancel buttons to EditMountPointOptionsDialog.

M  +8    -0    src/gui/editmountoptionsdialog.cpp

http://commits.kde.org/partitionmanager/af140882a7a65c1d38869c2aff9f8ccb5fa95eb5
Comment 2 Andrius Štikonas 2016-06-15 13:51:28 UTC
Also added placeholder text to guide user.
Comment 3 lorenzo 2016-06-15 17:39:23 UTC
Thank you!