Bug 364147 - Too big window preview when hovering mouse on task manager
Summary: Too big window preview when hovering mouse on task manager
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL: http://s33.postimg.org/3y3tldqbz/Scre...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-09 13:33 UTC by thanosshadow5
Modified: 2018-02-27 16:17 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
hein: VisualDesign+


Attachments
... (379.67 KB, image/png)
2016-06-09 13:35 UTC, thanosshadow5
Details
Tooltip size (415.08 KB, image/png)
2016-06-19 12:31 UTC, rndbit
Details
Blurry app icon (45.62 KB, image/png)
2016-07-15 09:40 UTC, Janek Bevendorff
Details
Blurry Icons 2 (152.81 KB, image/png)
2016-07-15 09:51 UTC, Janek Bevendorff
Details
Windows 10 window preview (150.10 KB, image/png)
2016-07-26 13:41 UTC, thanosshadow5
Details

Note You need to log in before you can comment on or make changes to this bug.
Description thanosshadow5 2016-06-09 13:33:09 UTC
I was watching a video and hovering the mouse on the task manager blocks 1/3rd of the screen in height. And I don't even get to see what the terminal is doing (no preview)

I think the words "pharmathan: sudo - Konsole" have to go or be smaller, because they take too much space.

Reproducible: Always
Comment 1 thanosshadow5 2016-06-09 13:34:08 UTC
See the url for the screenshot
Comment 2 thanosshadow5 2016-06-09 13:35:13 UTC
Created attachment 99423 [details]
...

...
Comment 3 Eike Hein 2016-06-10 08:12:32 UTC
Something for the VDG.
Comment 4 Thomas Pfeiffer 2016-06-10 12:44:13 UTC
Not much use to work on that at this moment from my perspective, because we have big plans for those tooltips: Instead of making them smaller, we want to make them actually useful.
When we have some designs for that, we'll look what size they need to be useful.
Comment 5 Eike Hein 2016-06-11 09:38:02 UTC
That sounds nice Thomas, as the Task Manager maintainer I'm not very happy with the tooltips currently.
Comment 6 rndbit 2016-06-19 12:31:59 UTC
Created attachment 99604 [details]
Tooltip size
Comment 7 rndbit 2016-06-19 12:34:14 UTC
Ok sorry for double-comment, this attachment system is very confusing.

I added image that shows how pausing/resuming media gives different tooltip sizes for some reason. I think this is somewhat related. Plasma should cap tooltip size isntead of allowing it to be as big or as small as it desires. Now actually tooltip of every application in taskbar has different size. It is just confusing and bad looking.
Comment 8 Janek Bevendorff 2016-07-15 09:40:56 UTC
Created attachment 100111 [details]
Blurry app icon

Since you said that you're reworking tooltips anyway (I would love that), I don't create a new issue for that and just add it as a remark here: it would be nice if you could also make them prettier. There are two major issues with the current look and feel:

a) no animations which makes tooltips feel like compositing is turned off
b) blurry (i.e. scaled-up) application icons when windows are minimized (see attached screenshot)

Further explanation of b): icons with higher resolution definitely exist as I can see when I make the panel bigger. The tooltip still uses a scaled-down version, though. This does not happen for all applications, though. KDE apps (maybe Qt apps in general? Not sure) seem to show icons at correct sizes when windows are minimized. But icons of GTK apps (such as Chrome or Gimp) are usually scaled up and look blurry.
Comment 9 Eike Hein 2016-07-15 09:45:14 UTC
Please make sure that:

1) You use Plasma 5.7 for thest tests due to the fully-rewritten backend

2) You use a less broken app than Chrome for testing - in cases where we can't map the window to a system-registered app we fall back to the window icon which may not be high-res, and Chrome is notoriously bad at providing correct metadata
Comment 10 Janek Bevendorff 2016-07-15 09:49:17 UTC
I'm using 5.7.1 and I tested it with Chrome and Gimp (as written above). However, Gimp also uses a different icon for the taskbar entry (provided by the Breeze icon theme, I guess) than in the tooltip (standard Gimp icon). Thunderbird seems to show the tooltip icon at a correct size.

But still, even if it's just Chrome: it's such a widely-used application that there should be a fix/workaround even if it's not really KDE's fault.
Comment 11 Janek Bevendorff 2016-07-15 09:51:49 UTC
Created attachment 100112 [details]
Blurry Icons 2

I attached a new screenshot showing Gimp and Chrome and a very big panel. Both apps have icons with correct resolution on the panel, but both show blurry icons in their tooltips.
Comment 12 rndbit 2016-07-15 10:07:58 UTC
I think this boils down to kde not enforcing tooltip size and every application having free reign on resizing that tooltip by providing images of different size.
Comment 13 Eike Hein 2016-07-15 10:12:46 UTC
> But still, even if it's just Chrome: it's such a widely-used application that there should be a fix/workaround even if it's not really KDE's fault.

We ship hacks for Chrome in taskmanagerrulesrc for that reason, but they invent new ways to break it from time to time.
Comment 14 Eike Hein 2016-07-15 10:13:45 UTC
> I think this boils down to kde not enforcing tooltip size and every application having free reign on resizing that tooltip by providing images of different size.

No. Applications have no influence on the size of the Task Manager tooltips.
Comment 15 Eike Hein 2016-07-15 10:16:21 UTC
>  I attached a new screenshot showing Gimp and Chrome and a very big panel. Both apps have icons with correct resolution on the panel, but both show blurry icons in their tooltips.

Confirmed. Looks like tooltips don't use the task button icon when there is no thumbnail, but fall back to the (low-res) window icon pixmap instead.
Comment 16 Eike Hein 2016-07-15 10:21:06 UTC
Kai, Martin, VDG: Which way do we want to go with this? Things I can think of:

1) Evaluate on the QML side if the thumbnail is actually available (based on some sort of WindowThumbnail prop that may or may not exist yet) and substitute WindowThumbnail for an IconItem using TasksModel's deco prop in that case

2) add a fallBackIcon prop to WindowThumbnail and set TasksModel's deco prop on it, make WindowThumbnail paint that instead of the window icon (probably dumb since it bypasses a lot of IconItem smartness)

3) Figure out if WindowThumbnail could somehow try harder to get a higher-res window icon. Probably fruitless. On the other hand showing the task button icon twice in the tooltip seems pointless too.

4) Fix the tooltip animation effect to avoid the Flappy Bird-like movement and hide the entire preview when the thumb is not available
Comment 17 rndbit 2016-07-15 10:34:29 UTC
> No. Applications have no influence on the size of the Task Manager tooltips.

Really? Because every application has tooltip of different length here (which is plasma 5.7), and pausing/resuming spotify via tooltip also changes length thus moving buttons from under the mouse. Height seems consistent though. By the way my taskbar is on the left edge of screen if it has any importance.
Comment 18 Martin Flöser 2016-07-15 10:39:18 UTC
I think option 1 sounds like the best solution.
Comment 19 Thomas Pfeiffer 2016-07-15 12:03:35 UTC
The WindowMetaData framework which is currently being developed changes the whole situation for thumbnails, anyway, doesn't it?

The question really is: What do we show for applications which provide nothing? What benefit does a huge icon bring to users?

When we have nothing relevant to show either via WindowMetaData or via MPRIS, I'd just show a button to close the window and that's it.
Comment 20 rndbit 2016-07-15 12:29:51 UTC
How about preview of application window? If preview is not available then window icon sounds like sane fallback until preview can be displayed. Since this is what windows does i think it is a safe bet. New users some would get what they expect too.
Comment 21 Janek Bevendorff 2016-07-15 17:43:00 UTC
I agree that showing a big icon is not really helpful, especially not
because there is already an icon right next to the title. A fine fix for
me would also be to just make the tooltip smaller and only show the
title (+ the smaller icon on the right-hand side). But having a big
blurry icon whose native resolution is way too low is just a no-go.
Comment 22 thanosshadow5 2016-07-26 13:40:03 UTC
Hey good afternoon. What are you still discussing about? Is it so hard to make the window preview smaller? 

I'll add an attachment with a screenshot of how windows 10 manages windows' previews. Simple and useful. I don't get it why you make your lives so hard ^_^
Comment 23 thanosshadow5 2016-07-26 13:41:57 UTC
Created attachment 100312 [details]
Windows 10 window preview

See the preview window on the bottom? It shows what needs to be shown and doesn't take 1/3rd of my screen
Comment 24 thanosshadow5 2016-07-26 13:43:14 UTC
* 1/3rd of its height
Comment 25 Nate Graham 2017-12-13 23:10:43 UTC
Is this still reproducible using recent Plasma versions? I don't see this behavior in 5.11. The tooltips seem to be fairly reasonably sized.
Comment 26 Alexander Mentyu 2018-02-27 15:33:58 UTC
I tested previews for some apps - SMPlayer, VLC, Kate, KSysGuard, Dolphin, Discover, Chromium, Chrome, GIMP, Inkscape, PyCharm - and noticed that VirtualBox app currently has blurry icon in preview - all others apps are looking ok 

Plasma: 5.12.2
Apps: 17.12.2
Frameworks: 5.43.0
Qt: 5.10.1
Kernel: 4.14.20-2-MANJARO
OS: Netrunner Rolling
Comment 27 Nate Graham 2018-02-27 16:17:31 UTC
The original issue here has definitely been fixed; tooltips for not-running apps are now nice and small. Let's track any new issues with new bugs. Thanks everyone!