Bug 364035 - GPS correlation fails to save coordinates back to files
Summary: GPS correlation fails to save coordinates back to files
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Geolocation-Correlator (show other bugs)
Version: 5.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-06 19:36 UTC by matburnham+kdebugs
Modified: 2018-07-29 13:30 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description matburnham+kdebugs 2016-06-06 19:36:45 UTC
After loading a GPX file, and correlating this to a set of photos (succesfully, as far as I can tell) Applying this change back to the files fails with a dialog saying it couldn't write to the files.

DebugView shows the following:

[12932] digikam.geoiface: ----
[12932] digikam.geoiface: "created cluster 0: 1 tiles"
[12932] digikam.geoiface: "level 5: 1 non empty tiles sorted into 1 clusters (1 searched)"
[12932] digikam.metaengine: Cannot load metadata from file   (Error # 9 :  /C:/Users/Mat/Pictures/.../IMG_0259.CR2: Failed to open the data source: Invalid argument (errno = 22)
[12932] digikam.geoiface: "created cluster 0: 1 tiles"
[12932] digikam.geoiface: "level 5: 1 non empty tiles sorted into 1 clusters (1 searched)"
[5032] ds\security\umstartup\usermgr\cli\usermgrcli.cxx(165)\usermgrcli.dll!00007FFFDF3510FF: (caller: 00007FFFCCE691AB) ReturnHr[PreRelease](1681) tid(1a50) 80070005 Access is denied. 
[5032] base\appmodel\execmodel\modern\lifetimemanager\appxexecutionutil.cpp(40)\modernexecserver.dll!00007FFFCCE6928C: (caller: 00007FFFCCE7DCA5) ReturnHr[PreRelease](1750) tid(1a50) 80070005 Access is denied. 
[12932] digikam.metaengine: Cannot load metadata from file   (Error # 9 :  /C:/Users/Mat/Pictures/.../IMG_0260.CR2: Failed to open the data source: Invalid argument (errno = 22)
[12932] digikam.geoiface: ----
[12932] digikam.metaengine: Cannot load metadata from file   (Error # 9 :  /C:/Users/Mat/Pictures/.../IMG_0259.JPG: Failed to open the data source: Invalid argument (errno = 22)
[5032] ds\security\umstartup\usermgr\cli\usermgrcli.cxx(165)\usermgrcli.dll!00007FFFDF3510FF: (caller: 00007FFFCCE691AB) ReturnHr[PreRelease](1682) tid(1a50) 80070005 Access is denied. 
[5032] base\appmodel\execmodel\modern\lifetimemanager\appxexecutionutil.cpp(40)\modernexecserver.dll!00007FFFCCE6928C: (caller: 00007FFFCCE7DCA5) ReturnHr[PreRelease](1751) tid(1a50) 80070005 Access is denied. 
[12932] digikam.metaengine: Cannot load metadata from file   (Error # 9 :  /C:/Users/Mat/Pictures/.../IMG_0260.JPG: Failed to open the data source: Invalid argument (errno = 22)
[12932] digikam.general: 0 1
[12932] digikam.geoiface: ----

This repeats for each file. I imagine it'll struggle on the CR2 files, but the JPGs should work. It currently fails on both.

Reproducible: Always

Steps to Reproduce:
1. Load GPX file.
2. Correlate.
3. Apply.

Actual Results:  
Dialog: "Error: Digicam failed to save some information" and a list of files.

Expected Results:  
Geolocation data added to files.
Comment 1 Maik Qualmann 2016-06-07 10:35:35 UTC
Git commit def4db95e0d5e759e0f28d3a254984488f365a69 by Maik Qualmann.
Committed on 07/06/2016 at 10:34.
Pushed by mqualmann into branch 'master'.

fix file path for Windows
FIXED-IN: 5.0.0

M  +2    -1    NEWS
M  +3    -1    utilities/geolocation/editor/correlator/gpscorrelatorwidget.cpp
M  +4    -4    utilities/geolocation/editor/items/gpsimageitem.cpp
M  +1    -1    utilities/geolocation/editor/items/gpsimagemodel.cpp

http://commits.kde.org/digikam/def4db95e0d5e759e0f28d3a254984488f365a69
Comment 2 caulier.gilles 2016-06-07 14:32:25 UTC
Windows installer have been updated with these last changes :

https://drive.google.com/open?id=0B7yq-xFihT0_SzhxVzF1RDhPbFE

Gilles Caulier
Comment 3 matburnham+kdebugs 2016-06-07 18:46:02 UTC
Reinstalled latest version from Google drive link*, but I still see the same error on screen. Associated Log is as follows:

[4692] shell\twinui\nowplayingsessionmanager\localprovider\baseprovider\lib\baseprovider.cpp(516)\NPSMDesktopProvider.dll!00007FFFD412E7E8: (caller: 00007FFFD4124A09) ReturnHr[PreRelease](342) tid(1998) 80070490 Element not found. 
[5280] digikam.geoiface: "level 7: 0 non empty tiles sorted into 0 clusters (0 searched)"
[5032] ds\security\umstartup\usermgr\cli\usermgrcli.cxx(165)\usermgrcli.dll!00007FFFDF3510FF: (caller: 00007FFFCCE691AB) ReturnHr[PreRelease](1868) tid(10a0) 80070005 Access is denied. 
[5032] base\appmodel\execmodel\modern\lifetimemanager\appxexecutionutil.cpp(40)\modernexecserver.dll!00007FFFCCE6928C: (caller: 00007FFFCCE7DCA5) ReturnHr[PreRelease](2034) tid(10a0) 80070005 Access is denied. 
[5280] digikam.metaengine: Cannot load metadata from file   (Error # 9 :  /C:/Users/Mat/Pictures/.../IMG_0200.CR2: Failed to open the data source: Invalid argument (errno = 22)
[5280] digikam.geoiface: ----

(Repeats for each file).

Not sure of status to shift this to so reverted to UNCONFIRMED.

* Is there a way I can confirm which version I've got? I'm sure I reinstalled from the correct file but it would be good to confirm for definite
Comment 4 Maik Qualmann 2016-06-07 19:54:32 UTC
Git commit d8f05410600b6677d2ae77c4422cbdbaf3a7d178 by Maik Qualmann.
Committed on 07/06/2016 at 19:52.
Pushed by mqualmann into branch 'master'.

fix sidecar file url

M  +1    -4    libs/dmetadata/metaengine.cpp

http://commits.kde.org/digikam/d8f05410600b6677d2ae77c4422cbdbaf3a7d178
Comment 5 Maik Qualmann 2016-06-07 20:11:29 UTC
I just just tested the installer from Google Drive, The fix is not included. With my Windows build the problem is solved. Please wait until Gilles updated the installer.

Maik
Comment 6 caulier.gilles 2016-06-08 05:54:01 UTC
I just updated the windows installer on GDrive :

https://drive.google.com/open?id=0B7yq-xFihT0_SzhxVzF1RDhPbFE

Gilles Caulier
Comment 7 caulier.gilles 2016-06-09 15:39:15 UTC
Any feedback please ?

Gilles Caulier
Comment 8 matburnham+kdebugs 2016-06-09 16:54:25 UTC
Sorry, I got round to installing it last night but not trying it out. Have just given it a go and all is good in the new build.

Well, I say that. It still reports failure to write to the Canon .CR2 RAW files, but I think that might be understandable. They appear to have EXIF data but its probably non-standard. JPG files worked fine.

Thanks.
Comment 9 caulier.gilles 2016-06-09 17:15:55 UTC
Writing to RAW files as CR2 is experimental and delegate to Exiv2. digiKam has an option in Metadata panel, but i recommend to use XMP sidecar as well to deal with read only files.

Gilles Caulier