Bug 363902 - git master: editing a transition does not invalidate preview chunks
Summary: git master: editing a transition does not invalidate preview chunks
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-03 15:32 UTC by Wegwerf
Modified: 2016-06-05 08:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-06-03 15:32:32 UTC
When editing a transition, in particular, when changing keyframes for fade in/out, etc., preview render chunks covered by this transition do not get invalidated. This causes timeline play to be out of sync with the actual timeline clip/transition configuration.

Reproducible: Always
Comment 1 Jean-Baptiste Mardelle 2016-06-04 21:44:26 UTC
Git commit 4bef7eb9367e985ad9e28df11ceccaf3c425c59e by Jean-Baptiste Mardelle.
Committed on 04/06/2016 at 21:44.
Pushed by mardelle into branch 'master'.

Timeline preview fixes
Related: bug 363900, bug 363904

M  +6    -3    src/doc/kdenlivedoc.cpp
M  +1    -0    src/doc/kdenlivedoc.h
M  +1    -1    src/main.cpp
M  +3    -1    src/mainwindow.cpp
M  +1    -0    src/mainwindow.h
M  +3    -0    src/mltcontroller/producerqueue.cpp
M  +2    -0    src/mltcontroller/producerqueue.h
M  +12   -5    src/project/dialogs/projectsettings.cpp
M  +1    -0    src/project/dialogs/projectsettings.h
M  +2    -2    src/project/projectmanager.cpp
M  +27   -21   src/timeline/customtrackview.cpp
M  +79   -35   src/timeline/managers/previewmanager.cpp
M  +16   -18   src/timeline/timeline.cpp
M  +3    -6    src/timeline/timelinecommands.cpp
M  +1    -1    src/timeline/timelinecommands.h
M  +35   -5    src/timeline/track.cpp
M  +2    -2    src/timeline/track.h
M  +2    -17   src/timeline/transitionhandler.cpp
M  +1    -1    src/timeline/transitionhandler.h
M  +1    -1    src/utils/progressbutton.cpp

http://commits.kde.org/kdenlive/4bef7eb9367e985ad9e28df11ceccaf3c425c59e
Comment 2 Wegwerf 2016-06-05 07:56:19 UTC
This now seems to be extremely sensitive to editing transitions and usually stops preview rendering with the an error "preview rendering failed, check your parameters". At this time, preview rendering hasn't yet reached the transition that was edited. For what it's worth, the preview rendering zone spans the whole project.

This render abort may be caused by my particular project setup, but at this time it makes editing transitions while preview rendering being active no fun, because rendering gets aborted as soon as I touch something.

Alas, my setup is as follows:
1. track: logo clip spanning the full width of the project; it has an affine transition with the bottom-most track. Track is unlocked.
2. track: titling with an affine transition: as soon as I edit the transition all preview rendering stops, even if rendering hasn't yet reached the part covered by the transition.
Comment 3 Wegwerf 2016-06-05 08:01:49 UTC
I only now notice that albeit the error message appearing in the status bar and the preview render progress bar turning red the rendering seems to resume after some seconds when not touching the preview render button. Strange...
Comment 4 Wegwerf 2016-06-05 08:11:54 UTC
Doing more editing I now don't get the error message anymore when editing transitions. Seems to be a bug related to my specific project setup. I will wait for it to pop up again and then I hopefully may be able to also come up with a simple regression project. So I'm closing this for now.

Jean-Baptiste, thank you very much again for your hard work! It is much appreciated!