Bug 363842 - [frameworks] Okular appstream data doesn't provide all supported mimetypes
Summary: [frameworks] Okular appstream data doesn't provide all supported mimetypes
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 14:20 UTC by Aleix Pol
Modified: 2016-11-09 10:31 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleix Pol 2016-06-02 14:20:45 UTC
$ appstreamcli get okular.desktop --details
Identifier: okular.desktop [desktop]
Name: Okular
Summary: Universal document viewer
Package: kdegraphics-okular
Icon: kdegraphics-okular_okular.png
Description: Document Viewer
Sample Screenshot URL: http://screenshots.debian.net/screenshot/kdegraphics-okular
Categories: Graphics, Office, Viewer, 
Provided Items: ↓
 Mimetypes: application/vnd.kde.okular-archive

Reproducible: Always
Comment 1 Aleix Pol 2016-06-02 14:24:20 UTC
Only  application/vnd.kde.okular-archive is offered, important others are missing, such as application/pdf.
Comment 2 Yuri Chornoivan 2016-06-02 14:48:54 UTC
Only KF5 version affected (Okular for KDE 4 does not have AppData file).

KF5 version's AppData file should include all Okular's desktop files as ids in "component" section.

Just my 2 cents.
Comment 3 Albert Astals Cid 2016-07-04 23:27:59 UTC
That's not a bug and is by design, did really the designers of the appstream format didnt' think of plugin-based applications? What are we in 1950?
Comment 4 Aleix Pol 2016-07-04 23:39:23 UTC
Nono, appstream can have addons. I guess we need to decide if we want to advertise the plugins in general or have an appdata file for each plugin.

It also depends on whether we're going to allow packagers to split the package.
Comment 5 Albert Astals Cid 2016-07-05 20:34:58 UTC
"It also depends on whether we're going to allow packagers to split the package."

It's not like we can control what crazyness packagers decide to do, right?
Comment 6 Aleix Pol 2016-07-05 20:54:18 UTC
They certainly claim they adhere to readmes and such. I guess splitting can make sense in the cases where it adds dependencies. If you want to maintain such freedom, then we can just add an appstream file for every plugin. Which is what evince does, if I recall correctly.
Comment 7 Albert Astals Cid 2016-07-05 21:19:13 UTC
one file per plugin makes sense to me
Comment 8 Burkhard Lück 2016-11-01 15:17:47 UTC
https://git.reviewboard.kde.org/r/128404/
Comment 9 Burkhard Lück 2016-11-04 14:16:52 UTC
appdata file + metadata files for chm, comicbook, djvu, dvi, epub, fax, fictionbook were added with https://git.reviewboard.kde.org/r/128404/ to kf5 master

metadata files for mobipocket, ooo, plucker, poppler, spectre, tiff, txt + xps are still missing
Comment 10 Burkhard Lück 2016-11-09 10:31:13 UTC
Git commit 4b7455396ef70eb40f3ccae93604f4d118cc8609 by Burkhard Lück.
Committed on 09/11/2016 at 10:30.
Pushed by lueck into branch 'master'.

add metadata for kimgio, mobipocket, ooo, plucker, poppler, spectre, txt, xps

REVIEW:129347

M  +1    -0    generators/kimgio/CMakeLists.txt
A  +36   -0    generators/kimgio/org.kde.okular-kimgio.metainfo.xml
M  +1    -0    generators/mobipocket/CMakeLists.txt
A  +36   -0    generators/mobipocket/org.kde.okular-mobipocket.metainfo.xml
M  +1    -1    generators/ooo/CMakeLists.txt
A  +13   -0    generators/ooo/org.kde.okular-ooo.metainfo.xml
M  +1    -0    generators/plucker/CMakeLists.txt
A  +13   -0    generators/plucker/org.kde.okular-plucker.metainfo.xml
M  +1    -1    generators/poppler/CMakeLists.txt
A  +16   -0    generators/poppler/org.kde.okular-poppler.metainfo.xml
M  +1    -0    generators/spectre/CMakeLists.txt
A  +18   -0    generators/spectre/org.kde.okular-spectre.metainfo.xml
M  +1    -0    generators/tiff/CMakeLists.txt
A  +13   -0    generators/tiff/org.kde.okular-tiff.metainfo.xml
M  +1    -0    generators/txt/CMakeLists.txt
A  +13   -0    generators/txt/org.kde.okular-txt.metainfo.xml
M  +1    -1    generators/xps/CMakeLists.txt
A  +13   -0    generators/xps/org.kde.okular-xps.metainfo.xml

http://commits.kde.org/okular/4b7455396ef70eb40f3ccae93604f4d118cc8609