Bug 363798 - Make the Action Buttons smaller
Summary: Make the Action Buttons smaller
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-01 15:05 UTC by Thomas Pfeiffer
Modified: 2019-04-23 15:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Illustration of the buttons sizes (4.84 KB, image/png)
2016-07-12 23:35 UTC, Thomas Pfeiffer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Pfeiffer 2016-06-01 15:05:55 UTC
Currently, the Action Buttons are a little too big.
Please resize them so that the secondary buttons have the same height as the drawer handles.

Reproducible: Always
Comment 1 Marco Martin 2016-07-12 11:22:16 UTC
should be fixed in master
Comment 2 Thomas Pfeiffer 2016-07-12 23:35:05 UTC
Created attachment 100051 [details]
Illustration of the buttons sizes

I just pulled and built, and secondary action buttons in the gallery are still considerably larger than the drawer handles. See attached screenshot
Comment 3 Thomas Pfeiffer 2016-07-19 11:47:12 UTC
Just updated from Master again, buttons are still too big.
Comment 4 Marco Martin 2016-08-02 10:57:49 UTC
Git commit 532b051fd31ab81d91b05a679e72f7bc115ef962 by Marco Martin.
Committed on 02/08/2016 at 10:55.
Pushed by mart into branch 'master'.

same size between secondary action buttons/handles

M  +2    -2    src/controls/private/ActionButton.qml

http://commits.kde.org/kirigami/532b051fd31ab81d91b05a679e72f7bc115ef962
Comment 5 Thomas Pfeiffer 2016-08-03 18:05:07 UTC
Just built from Master, and on desktop, the drawer handles are 32px hight whereas the secondary ABs are 40px. Something is wrong here...
Comment 6 Thomas Pfeiffer 2019-04-23 15:31:22 UTC
Fixed by now.