Bug 363794 - Ddolphin ignores Maxsize in breeze index.theme icon file.
Summary: Ddolphin ignores Maxsize in breeze index.theme icon file.
Status: RESOLVED NOT A BUG
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: general (other bugs)
Version First Reported In: 16.12.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL: http://wpage.unina.it/aorefice/sharev...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-01 13:27 UTC by Antonio Orefice
Modified: 2017-09-04 03:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Orefice 2016-06-01 13:27:38 UTC
Dolphin scales 22x22 sized icon file file to bigger sizes even if bigger sized icon files are specified in the theme file, (ex: breeze)

Reproducible: Always

Steps to Reproduce:
1. open dolphin and display some icons in the lowest possible size
2. scale them up using the dolphin silder to the max


Actual Results:  
The same 22x22 svg icon size is shown even for the bigger sizes.

Expected Results:  
Dolphin to pick a bigger sized file, as described in the .index theme file.


Maybe a video is clearer then my words:
dolphin q4 scaling icons, notice that the displayed image changes.
This means the picked icon image changes according to the icon size requested, which imho, is the right thing to do:
http://wpage.unina.it/aorefice/sharevar … in-qt4.ogv

dolphin qt5 scaling icons, notice that it always pick up the same file and scales it:
http://wpage.unina.it/aorefice/sharevar … in-qt5.ogv

According to https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
---
When type is "Scalable":
MinSize:    Specifies the minimum size that the icons in this directory can be scaled to. Defaults to the value of Size if not present. 
MaxSize:    Specifies the maximum size that the icons in this directory can be scaled to. Defaults to the value of Size if not present. 
---
and from breeze index.theme:
---
[mimetypes/16]
Size=16
Context=MimeTypes
Type=Fixed
MinSize=16

#22x22 - Fixed size - For small file type icons >!!!ONLY!!!< - DO_NOT_USE_ANYWHERE_ELSE - Monochrome
[mimetypes/22]
Size=22
Context=MimeTypes
Type=Scalable
MinSize=22
MaxSize=24
#32x32 - Scalable - For file type icons >!!!ONLY!!!< - Scalable to the following sizes: 64x64 (default), 32x32, 128x128, 256x256 - DO_NOT_USE_ANYWHERE_ELSE - Color
[mimetypes/32]
Size=32
Context=MimeTypes
Type=Scalable
MinSize=32
MaxSize=48

#64x64 - Scalable - For file type icons >!!!ONLY!!!< - Scalable to the following sizes: 64x64 (default), 32x32, 128x128, 256x256 - DO_NOT_USE_ANYWHERE_ELSE - Color
[mimetypes/64]
Size=64
Context=MimeTypes
Type=Scalable
MinSize=64
MaxSize=256
---
...but MaxSize=24 is ignored by dolphin qt5, it uses the first Scalable type icons for all of the bigger sizes.
Comment 1 Antonio Orefice 2016-06-01 13:30:20 UTC
Here are some media files that show the issue, and even compare the behaviour of dolphin in qt4 and dolphin qt5
http://wpage.unina.it/aorefice/sharevari/dolphin
Comment 2 Antonio Orefice 2016-06-01 14:00:14 UTC
I'm using the qt5ct plugin; somehow it works good in a full kde desktop; can't say why.
Comment 3 Mihai DONȚU 2016-06-07 01:35:28 UTC
This one happens on Gentoo too (Plasma 5.6.4, Frameworks 5.22.0) and was triggered by the latest Frameworks update. The symptoms are: dolphin shows the right icon only for directories on which I have set a custom one. All the rest, have the black-and-white icon (no matter the size). However, in gwenview, the file open dialog shows all of them just fine. I assume they are separate controls.

One other thing I noticed and I don't know if it's related: kate uses the Qt file open dialog for some reason ever since that update.
Comment 4 Christoph Feck 2016-11-11 16:42:15 UTC
You are probably lacking the plasma-integration package.
Comment 5 Mihai DONȚU 2016-11-11 16:59:23 UTC
You're right and the icon issue is gone as well.
Comment 6 Nate Graham 2017-09-04 03:58:02 UTC
Sounds like this was resolved by installing additional supporting packages.