Bug 363680 - add renameat2() support
Summary: add renameat2() support
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: 3.11.0
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-29 23:06 UTC by Jann Horn
Modified: 2016-05-31 12:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
adds renameat2 support (3.80 KB, patch)
2016-05-29 23:07 UTC, Jann Horn 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jann Horn 2016-05-29 23:06:51 UTC 
The renameat2() syscall (basically renameat() plus a flags argument) wasn't supported.

I'm going to attach a patch that fixes this if I can figure out how to do that in this bugtracker - it doesn't seem to be possible on the initial page for filing bugs?

Reproducible: Always
Comment 1 Jann Horn 2016-05-29 23:07:57 UTC 
Created attachment 99255 [details]
adds renameat2 support

Ah, I can attach stuff after submitting the bug. Attached my patch.
Comment 2 Mark Wielaard 2016-05-30 21:39:03 UTC 
Looks correct. It can probably also be added to the other coregrind/m_syswrap/syswrap-*-linux.c wrappers. Do you happen to have an example program that uses renameat2?
Comment 3 Jann Horn 2016-05-30 21:44:08 UTC 
No, I don't have an example program - I'm just using it in a private project.
Comment 4 Mark Wielaard 2016-05-31 12:16:45 UTC 
I see glibc also doesn't expose it yet. But the code looks fine.
Committed as valgrind svn r15889.
Thanks