Bug 363677 - background-size inherit/initial fails to apply in some cases
Summary: background-size inherit/initial fails to apply in some cases
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml renderer (other bugs)
Version First Reported In: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Konqueror Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-29 19:10 UTC by Andrea Iacovitti
Modified: 2016-05-29 21:30 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/kdelibs/dee3cce6f343c298fc23a1fdd77b880aacf3c354
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
image needed for testcase (515 bytes, image/png)
2016-05-29 19:11 UTC, Andrea Iacovitti 		Details
testcase1 - inherit (648 bytes, text/html)
2016-05-29 19:15 UTC, Andrea Iacovitti 		Details
testcase2 - initial (502 bytes, text/html)
2016-05-29 19:17 UTC, Andrea Iacovitti 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Iacovitti 2016-05-29 19:10:14 UTC 
background-size inherit/initial fails to apply in some cases, will upload testcases

Reproducible: Always
Comment 1 Andrea Iacovitti 2016-05-29 19:11:17 UTC 
Created attachment 99247 [details]
image needed for testcase
Comment 2 Andrea Iacovitti 2016-05-29 19:15:10 UTC 
Created attachment 99248 [details]
testcase1 - inherit
Comment 3 Andrea Iacovitti 2016-05-29 19:17:19 UTC 
Created attachment 99249 [details]
testcase2 - initial
Comment 4 Andrea Iacovitti 2016-05-29 21:30:48 UTC 
Git commit dee3cce6f343c298fc23a1fdd77b880aacf3c354 by Andrea Iacovitti.
Committed on 29/05/2016 at 21:25.
Pushed by aiacovitti into branch 'KDE/4.14'.

Fix applying Initial and Inherit for background-size property.
Need to set both type and lengths of bg-size, currently only lengths was
set using setBackgroundSize() (see HANDLE_BACKGROUND_VALUE macro).
Remove separate handling of type and lengths as they are interdependent
and use setBackgroundSize() to set both, making this code less error-prone
and avoiding dealing with the macro.

M  +8    -8    khtml/css/css_renderstyledeclarationimpl.cpp
M  +4    -8    khtml/css/cssstyleselector.cpp
M  +2    -2    khtml/rendering/render_box.cpp
M  +2    -5    khtml/rendering/render_style.cpp
M  +17   -9    khtml/rendering/render_style.h

http://commits.kde.org/kdelibs/dee3cce6f343c298fc23a1fdd77b880aacf3c354