Dear developers, the main game area has a gradient background applied to the grid which makes the latter really poorly visible. This is not a problem when playing with keyboard, as the selected cells are highlighted, but when playing with mouse you have to put too much focus into clicking the right cell, which kind of ruins the game. I see two possible solutions: a) highlight the cell on mouse hover as this is the case with keyboard play b) remove the gradient Best regards, Andrej
Solution a) should be easy to do. Another option would be to support themes like other KDE games do.
Created attachment 109787 [details] Patch to correct this problem Added an option under the settings menu to enable/disable a cursor under the mouse.
I'm not really a kblackbox player, but i'm reviewing the patch because i don't think anyone else will. Do we really need this to be an option? I think it really makes sense to always have the highlight follow the mouse, no?
I made it an option because I was worried the new behavior would be undesirable or annoying for players used to the current behavior. I can remove the option if it make more sense to always have the cursor on.
As said i'm not really a kblackbox player, so can't give a hard answer, but from looking at it i think we can at least enable it by default and if someone really dislikes it, they can go an disable it. I'll give a quick review to the patch and commit it if i don't think anything wrong.
Can i have your full name for proper authorship attribution?
Kevin Price.
Git commit cb6d38cadfc1225e164f596ce73bef42222d35a8 by Albert Astals Cid, on behalf of Kevin Price. Committed on 15/01/2018 at 23:10. Pushed by aacid into branch 'master'. Added an option under the settings menu to enable a cursor under the mouse Contains some tweaks by Albert Astals Cid (whitespaces et al) M +2 -0 kbbgraphicsitemball.cpp M +16 -1 kbbgraphicsitemblackbox.cpp M +11 -4 kbbgraphicsitemblackbox.h M +1 -2 kbbgraphicsitemcursor.h M +1 -1 kbblevelconfigurationpreview.cpp M +8 -1 kbbmainwindow.cpp M +1 -1 kbbmainwindow.h M +23 -2 kbbscalablegraphicwidget.cpp M +4 -0 kbbscalablegraphicwidget.h M +4 -1 kblackboxui.rc https://commits.kde.org/kblackbox/cb6d38cadfc1225e164f596ce73bef42222d35a8
As you see I commited your patch, i've also made two small follow up commits, please comment if you disagree https://cgit.kde.org/kblackbox.git/commit/?id=1b137d305d3c898ae292ebb761f7dcb505c7c9a6 https://cgit.kde.org/kblackbox.git/commit/?id=9b100d33a36e79c92a19fdd612b4d371e5705a0f