Bug 363565 - Krita keep reseting theme to 'Default' all the time... but I don't have a 'Default' theme :D
Summary: Krita keep reseting theme to 'Default' all the time... but I don't have a 'De...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-26 22:22 UTC by David REVOY
Modified: 2016-05-27 06:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
[ ^ patch to fix the bug, tested on my install ] (825 bytes, patch)
2016-05-26 22:22 UTC, David REVOY
Details
[ ^ screenshot of my glorious default theme :-) ] (64.01 KB, image/jpeg)
2016-05-26 22:55 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2016-05-26 22:22:28 UTC
Created attachment 99209 [details]
[ ^ patch to fix the bug, tested on my install ]

Hi, Krita reset theme to the 'Default' string all the time, even if a theme is specified by user as Krita dark, or Krita blender. ( eg. each two restart, krita.rc get forced to [theme] Theme=Default  ). 
It's an issue for my install, because I don't have a Default theme. The UI just reset by itself to a bright one trying to mimic my GTK theme and this theme is not listed in the Settings>Themes ( and on Cinnamon dekstop I can't change Plasma5 options ). 

With investigation, I found this bug was introduced by Boud on 9c13ccf760381b18790b2aab3caa51e3476f7dcc ( 2016-05-24 11:36 ) , and I tried to manually revert a part of this commit. After test, the behavior of my partial revert is working ; so I managed to attach a modest patch to this bug report. ( yes, I could push it to git~master, but I was too afraid to break everything.)
Comment 1 Quiralta 2016-05-26 22:53:20 UTC
Can confirm, this happens to me every other restart of Krita, Plasma, Archlinux here.
Comment 2 David REVOY 2016-05-26 22:55:17 UTC
Created attachment 99210 [details]
[ ^ screenshot of my glorious default theme :-)  ]
Comment 3 Halla Rempt 2016-05-27 06:58:35 UTC
Git commit 2387604848de833d648f25d949ca92273e7a09eb by Boudewijn Rempt.
Committed on 27/05/2016 at 06:56.
Pushed by rempt into branch 'master'.

M  +24   -79   libs/ui/thememanager.cpp
M  +0    -5    libs/ui/thememanager.h

http://commits.kde.org/krita/2387604848de833d648f25d949ca92273e7a09eb