Bug 363528 - [PATCH] Click on default avatar attempts to launch nonexistent kcm_useraccount
Summary: [PATCH] Click on default avatar attempts to launch nonexistent kcm_useraccount
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (other bugs)
Version First Reported In: 5.6.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-25 22:49 UTC by Jason Tibbitts
Modified: 2016-06-02 10:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.6.5
Sentry Crash Report:


Attachments
Patch fixing kcm_useraccount call (374 bytes, patch)
2016-05-25 22:49 UTC, Jason Tibbitts
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Tibbitts 2016-05-25 22:49:39 UTC
Created attachment 99192 [details]
Patch fixing kcm_useraccount call

There are two places in Header.qml which will attempt to bring up the control module for user management.  One if the user has defined an avatar and one if the default avatar is being shown.  Only the first one was fixed to account for the fact that kcm_useraccount was (unfortunately) replaced with user_manager.  (But that's another ticket.)

The attached patch should fix the other one.
Comment 1 Kai Uwe Broulik 2016-05-25 23:06:23 UTC
Thanks for your patch! Indeed I forgot to change the other MouseArea but I'll better change the code so we only have one to avoid code duplication.
Comment 2 Kai Uwe Broulik 2016-06-02 10:49:29 UTC
Git commit feac04468de1af30881b64c09e961424241e21ab by Kai Uwe Broulik.
Committed on 02/06/2016 at 10:49.
Pushed by broulik into branch 'Plasma/5.6'.

[Kickoff] Use a single MouseArea for opening user manager

Avoid code duplication which has already lead to inconsistencies.
FIXED-IN: 5.6.5

Differential Revision: https://phabricator.kde.org/D1732

M  +7    -18   applets/kickoff/package/contents/ui/Header.qml

http://commits.kde.org/plasma-desktop/feac04468de1af30881b64c09e961424241e21ab