When exiting from a patch review by committing (to git), the documentation toolview is opened even if it was not when the patch review plugin was activated. Also happens when the commit is cancelled. Reproducible: Always Steps to Reproduce: 1. Edit a project that is a git working copy 2. Commit the changes via KDevelop's built-in git/commit/commit, or cancel the commit Actual Results: Upon exit from the patch review plugin/toolview I find myself looking at the documentation view, which I didn't request (and which typically doesn't show anything useful in this case). Expected Results: One expects that the view is restored exactly as it was before, with the same files open, the same document active, and no newly activated views. This was also an issue with KDevelop 4.7 until at some point it stopped. I've never been able to determine if that was because of a code change or because of something I did locally (to the runtime state). I'd hope it's the former, though.
It doesn't make sense. Also I can't reproduce. Also documentation isn't mentioned on patch review at all. Please reopen if you find any pointers on what can be going on.
I agree it doesn't make any sense, but still it is what's happening. With all due respect, what's the point in accepting bug reports if you leave it to the reporter to figure out what's going on, and *close* the report in the meantime? You cannot expect everyone who's ever made small contributions to the code to know where to start looking for this kind of weirdness if the codebase is as huge and complex as kdevplatform + kdevelop ... Do I have to film my screen to prove I'm not talking out the side of my neck?
Another thing: where in the code could I set a breakpoint to catch whatever it is that causes the documentation view to open, or indeed to be reactivated after it's been removed from the visible toolviews?
Created attachment 100966 [details] screen recording showing the issue Sorry for the slightly nauseating hand-held video; I don't do this often enough to have proper screencasting tools
Could be a problem upon restoring the session. Do you get the same problem when debugging and getting back to code?
Indeed, same thing when the debugged application terminates and the debug view is closed. Could this be something like a missing variable initialisation? I've already encountered situations where that led to issues on only some platforms, but not with development builds. As I mentioned in the original report, I did see similar behaviour in KDevelop4 on OS X, and somehow it was always the documentation toolview that kept opening. At least it seems I can no longer reproduce the reactivation of that toolview when I've removed it from the toolbar. That's an acceptable workaround for me but probably not for everyone.
Well, I thought I could simply work around this issue by removing the Documentation button from my toolbars. While that's true I have to repeat the action each time I restart KDevelop because that damn. button keeps coming back...
(posted too fast) Wouldn't that give a hint at what's going here, i.e. "simply" a lack of persistence of the documentation view's settings?
I think that what happens is that the review and debug areas have its own setting for the documentation visibility, and that somehow the visibility isn't restored properly when going back to the code area. Why the documentation view actually opens when it wasn't in the review (or debug) area beats me...