Bug 363478 - git master: existing play/pause action is lost, please add it back
Summary: git master: existing play/pause action is lost, please add it back
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Display & Export (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-24 19:00 UTC by Wegwerf
Modified: 2016-05-25 16:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-05-24 19:00:26 UTC
So far, Kdenlive offered separate actions for "play zone", "play/pause", and "pause". With recent git master, the action "play/pause" has been removed. Please bring back "play/pause" which is quite useful, especially when working with a ShuttlePro jog dial: this combined action requires only a single physical button and physical buttons are rather limited in number on the ShuttlePro.

Reproducible: Always
Comment 1 Jean-Baptiste Mardelle 2016-05-24 23:11:17 UTC
I think the "Play" action in fact behaves as Play/Pause. So assigning a shortcut or button to it should allow you to do both actions, like spacebar currently does
Comment 2 Wegwerf 2016-05-25 06:59:03 UTC
Unfortunately, it does not (I checked before reporting to make sure). The reason I noticed was because onr ShuttlePro hardware key was reassigned its action to the first available action, add clip. Then I reassigned ... and found no play, only play zone. But pause doesn't work as play/pause when I tried.
Comment 3 Jean-Baptiste Mardelle 2016-05-25 08:59:22 UTC
Git commit 0c299425e13f41a76509c3213027ee5f9316b6cc by Jean-Baptiste Mardelle.
Committed on 25/05/2016 at 08:59.
Pushed by mardelle into branch 'master'.

Fix play action not correctly added to collection

M  +5    -3    src/mainwindow.cpp
M  +1    -12   src/monitor/monitormanager.cpp

http://commits.kde.org/kdenlive/0c299425e13f41a76509c3213027ee5f9316b6cc
Comment 4 Wegwerf 2016-05-25 16:13:28 UTC
Works now again as expected. Thank you very, Jean-Baptiste, much for fixing this regression!