Bug 363398 - Dialog "File" -> "Verify checksum" improvement
Summary: Dialog "File" -> "Verify checksum" improvement
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.4.0-beta3 "Single Step"
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-22 11:43 UTC by Rod J
Modified: 2018-05-06 00:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rod J 2016-05-22 11:43:24 UTC
This is the scenario: 

So, I have a downloaded ISO file and a matching downloaded checksum file in a specific folder.  The checksum filename is the same as the ISO file but with a .md5 or .sha256 extension (I always do this for downloaded ISO files; good practice I think). 

My question is: Why does the verify checksum dialog unnecessarily expect me to navigate to the checksum file all over again? It seems to me, it should automatically look in the ISO file's folder and see that there is a checksum file with the same name and choose that file by default. Would save a lot of time.

Just a suggestion. :-)
Comment 1 Rod J 2016-05-22 11:51:50 UTC
Example filenames:

/Rod/DVD-CD_Images/kubuntu-14.04.4-desktop-amd64.iso
/Rod/DVD-CD_Images/kubuntu-14.04.4-desktop-amd64.iso.sha256
Comment 2 Alex Bikadorov 2017-03-14 20:35:40 UTC
Usage changed: you select the checksum file (containing the hashes) and start the dialog with it.
Comment 3 Alex Bikadorov 2017-03-14 20:44:05 UTC
Git commit 2c5d47aed7c76679b5085a1fa8906d025524ceb8 by Alexander Bikadorov.
Committed on 14/03/2017 at 20:05.
Pushed by abikadorov into branch 'master'.

Dialogs: rework of entire checksum dialog classes

* Dialogs now QWizards.
* Removed support for *deep tools. Standard tools can create/verify checksums in directories now.
* Verify dialog should now be invoked with checksum file, not the files to check. Required for...
* ...important bug fix: standard tools did not verify selected files, but only files in checksum file.

M  +1    -0    CMakeLists.txt
M  +1    -0    krusader/CMakeLists.txt
M  +410  -539  krusader/Dialogs/checksumdlg.cpp
M  +140  -48   krusader/Dialogs/checksumdlg.h
M  +0    -5    krusader/Konfigurator/kgdependencies.cpp
M  +0    -15   krusader/Konfigurator/krresulttable.cpp
M  +18   -35   krusader/Panel/panelfunc.cpp
M  +1    -0    krusader/Panel/panelfunc.h
M  +1    -2    krusader/krservices.cpp
M  +0    -3    krusader/krusader.cpp

https://commits.kde.org/krusader/2c5d47aed7c76679b5085a1fa8906d025524ceb8