Bug 363229 - Bad RA and Dec in SkyPoint, when Alt and Az set by INDI
Summary: Bad RA and Dec in SkyPoint, when Alt and Az set by INDI
Status: RESOLVED FIXED
Alias: None
Product: kstars
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.2.0
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Jasem Mutlaq
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-18 16:30 UTC by Robert Munyer
Modified: 2016-05-19 06:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 16.08
Sentry Crash Report:


Attachments
quick-and-dirty HORIZONTAL_COORD patch (1.50 KB, text/plain)
2016-05-18 16:30 UTC, Robert Munyer
Details
quick-and-dirty HORIZONTAL_COORD patch (831 bytes, patch)
2016-05-18 16:33 UTC, Robert Munyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munyer 2016-05-18 16:30:01 UTC
Created attachment 99053 [details]
quick-and-dirty HORIZONTAL_COORD patch

When an INDI device sends a setNumberVector command with name="HORIZONTAL_COORD", the crosshair is shown at an unreasonable location: not the location specified by the device, sometimes not even on the celestial sphere!

A small patch is attached.  This is a quick-and-dirty patch, written by someone who hasn't read any kstars developer documentation, so don't trust it blindly; it may introduce other bugs.  It does, however, make kstars's behavior _seem_ much more reasonable, in the simple ad-hoc tests that I've tried.

P.S. I tried to exercise good bug report etiquette, by reporting against the current development version instead of an old Debian version.  But I found that the current build instructions don't work, so I went back to the Debian version.

The page

https://techbase.kde.org/Projects/Edu/KStars/Building_KStars_KF5

says to run the command

sudo apt-get install build-essential cmake git libeigen3-dev libcfitsio-dev zlib1g-dev libindi-dev extra-cmake-modules libkf5plotting-dev libqt5svg5-dev libkf5iconthemes-dev libkf5xmlgui-dev kio-dev libkf5init-dev kinit-dev libkf5newstuff-dev kdoctools-dev libkf5notifications-dev

, which fails on "libkf5init-dev".  Here is packages.debian.org's response to a search for libkf5init-dev:

You have searched for packages that names contain libkf5init-dev in all suites, all sections, and all architectures.

Sorry, your search gave no results
Comment 1 Robert Munyer 2016-05-18 16:33:12 UTC
Created attachment 99054 [details]
quick-and-dirty HORIZONTAL_COORD patch

Please ignore previous attachment; this is the right one.
Comment 2 Jasem Mutlaq 2016-05-19 06:10:25 UTC
Git commit c49b547595ce38648c7f81dc1034555bf2d86fc1 by Jasem Mutlaq.
Committed on 19/05/2016 at 06:08.
Pushed by mutlaqja into branch 'master'.

Applying patch by Robert Munyer to fix display of HORIZONTAL_COORD updates by INDI devices. Thanks Robert!
FIXED-IN:16.08

M  +1    -0    kstars/indi/inditelescope.cpp
M  +1    -0    kstars/skymapdrawabstract.cpp

http://commits.kde.org/kstars/c49b547595ce38648c7f81dc1034555bf2d86fc1