Bug 363111 - ki18n 5.22.0 compile fails with 'translation_found' was not declared in this scope
Summary: ki18n 5.22.0 compile fails with 'translation_found' was not declared in this ...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-ki18n
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.22.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Chusslove Illich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-15 22:52 UTC by Jan-Matthias Braun
Modified: 2016-05-16 22:03 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Fix the compile by moving the definition before the #ifdef. (503 bytes, patch)
2016-05-15 22:52 UTC, Jan-Matthias Braun 		Details
Patch v2: make the first use of translation_found the definition. (860 bytes, patch)
2016-05-15 23:02 UTC, Jan-Matthias Braun 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Matthias Braun 2016-05-15 22:52:26 UTC 
Created attachment 98998 [details]
Fix the compile by moving the definition before the #ifdef.

The variable translation_found is defined in the else branch of the #ifdef _LIBGETTEXT_HAVE_VARIABLE_SIZE_ARRAYS block in gettext.h before line 180, but used unconditionally in line 180.

The compile fails with
/var/tmp/portage/kde-frameworks/ki18n-5.22.0/work/ki18n-5.22.0/src/gettext.h:180:9: error: 'translation_found' was not declared in this scope
         translation_found = !(translation == msg_ctxt_id || translation == msgid_plural);
         ^
Comment 1 Jan-Matthias Braun 2016-05-15 23:02:30 UTC 
Created attachment 98999 [details]
Patch v2: make the first use of translation_found the definition.
Comment 2 Chusslove Illich 2016-05-15 23:16:50 UTC 
This was already fixed, but apparently a few hours too late for 5.22. I'll add release team to CC, if any remedy before 5.23 is in order.
Comment 3 David Faure 2016-05-16 22:03:14 UTC 
sources/ki18n-5.22.1.tar.xz uploaded for packagers.