Bug 362709 - kio_sftp.cpp:1239]: (style) Suspicious condition
Summary: kio_sftp.cpp:1239]: (style) Suspicious condition
Status: RESOLVED NOT A BUG
Alias: None
Product: kio-extras
Classification: Frameworks and Libraries
Component: default (show other bugs)
Version: unspecified
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Development Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-05 15:30 UTC by dcb314
Modified: 2016-06-20 04:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2016-05-05 15:30:54 UTC 
../../../kioslave/sftp/kio_sftp.cpp:1239]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

    } else if ((errorCode = writeToFile(fd, filedata.constData(), filedata.size()) != 0)) {

Suggest new code

    } else if ((errorCode = writeToFile(fd, filedata.constData(), filedata.size())) != 0) {


Reproducible: Always
Comment 1 Christoph Feck 2016-06-20 04:01:11 UTC 
Replaced with bug 364381.