Bug 362578 - deployment-file.json template hardcodes "android-extra-plugins" to share/ or lib/qml/
Summary: deployment-file.json template hardcodes "android-extra-plugins" to share/ or ...
Alias: None
Product: extra-cmake-modules
Classification: Frameworks and Libraries
Component: AndroidToolchain (show other bugs)
Version: 5.20.0
Platform: Other Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Aleix Pol
Depends on:
Reported: 2016-05-02 08:19 UTC by Friedrich W. H. Kossebau
Modified: 2016-05-03 15:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.22.0


Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2016-05-02 08:19:45 UTC
Projects that install nothing to either share/ or lib/qml (e.g. when using qrc files) will result in the qtdeploy program to fail complaining about missing dirs.

That is because the deployment-file.json template currently hardcodes "android-extra-plugins" to "@CMAKE_INSTALL_PREFIX@/share,@CMAKE_INSTALL_PREFIX@/lib/qml".

Please find a proposed change which patches specifydependencies.cmake to first check if any of those paths actually exists at https://git.reviewboard.kde.org/r/127700/
Comment 1 Friedrich W. H. Kossebau 2016-05-03 15:00:48 UTC
Git commit e0cfec7848ba63190957e107c7ef32dbe0119c42 by Friedrich W. H. Kossebau.
Committed on 03/05/2016 at 15:00.
Pushed by kossebau into branch 'master'.

Android deployment: support projects without things in share or lib/qml

Just setting the field android-extra-plugins to an empty string resulted
in androiddeployqt complaining about
"External resource  does not exist or not a correct directory!"
so the field is completely left out now if no plugin data dirs are found.
For consistency the same is done with the android-extra-libs field.

REVIEW: 127700

Thanks apol for review

M  +1    -1    toolchain/Android.cmake
M  +2    -2    toolchain/deployment-file.json.in
M  +19   -0    toolchain/specifydependencies.cmake