Bug 362477 - Excessive number of password prompts
Summary: Excessive number of password prompts
Status: RESOLVED FIXED
Alias: None
Product: trojita
Classification: Unmaintained
Component: Desktop GUI (show other bugs)
Version: git
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Trojita default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-29 20:35 UTC by Jan Kundrát
Modified: 2016-05-06 16:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kundrát 2016-04-29 20:35:57 UTC
1) Start Trojita configured to auto-connect, with no stored passwords, an active tray icon, available INBOX and unread e-mails
2) Forget about it, go away from the computer for a few hours
3) See dozens of password prompts
4) ???
5) Profit!
Comment 1 Jan Kundrát 2016-05-06 16:12:20 UTC
Git commit 8eb1279ae8388cbaa2fa0f4e5433f42e6a5762bd by Jan Kundrát.
Committed on 04/05/2016 at 14:35.
Pushed by gerrit into branch 'master'.

Requse password dialog on network reconnect cycles

When Trojita was started in its default settings (go online when
possible, do not remember passwords, watch for network session state
changes), no password was available and the network got cycled, a new
password prompt was opened. This patch ensures that if a password
request is pending, no additional prompts are enqueued.

This is implemented in the IMAP Model, so it isn't GUI-specific.
Change-Id: I4b14f06bc70b3580f16b0bfa4e47fcdb98b9d353

M  +3    -3    src/Imap/Model/Model.cpp
M  +6    -1    src/Imap/Model/Model.h
M  +20   -7    src/Imap/Tasks/OpenConnectionTask.cpp
M  +6    -0    src/Streams/FakeSocket.cpp
M  +2    -0    src/Streams/FakeSocket.h
M  +32   -0    tests/Imap/test_Imap_Tasks_OpenConnection.cpp
M  +2    -0    tests/Imap/test_Imap_Tasks_OpenConnection.h

http://commits.kde.org/trojita/8eb1279ae8388cbaa2fa0f4e5433f42e6a5762bd