Bug 362447 - Kate uses wrong icon for closing documents
Summary: Kate uses wrong icon for closing documents
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-28 22:09 UTC by Uri Herrera
Modified: 2016-04-30 21:08 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Uri Herrera 2016-04-28 22:09:36 UTC
When enabled Kate toolbar icons use the correct icons with the exception of "Close document" this button uses [window-close] when it should use [document-close]. The button clearly states that it's for closing the document not the window and clicking it when there's no open documents doesn't close Kate.

Reproducible: Always

Steps to Reproduce:
1. Open Kate
2. Enable toolbar
3. Change window-close to something else
4. Kate picks up this change

Actual Results:  
Kate uses an icon that doesn't match the action

Expected Results:  
Kate uses an icon that matches the action

This change is as simple as changing the line of code that calles for window-close to document-close.
Comment 1 Dominik Haumann 2016-04-30 21:02:42 UTC
Git commit 72cb3b9c71fd0a300ca163b8a644bc51e7b80eaf by Dominik Haumann.
Committed on 30/04/2016 at 21:02.
Pushed by dhaumann into branch 'Applications/16.04'.

Close document: use icon document-close instead of window-close

M  +3    -2    kate/katemainwindow.cpp

http://commits.kde.org/kate/72cb3b9c71fd0a300ca163b8a644bc51e7b80eaf
Comment 2 Dominik Haumann 2016-04-30 21:08:27 UTC
Git commit 0852d41175169219925773a4991f58c48a39d8bc by Dominik Haumann.
Committed on 30/04/2016 at 21:08.
Pushed by dhaumann into branch 'Applications/16.04'.

KWrite: use proper document close icon

M  +1    -0    kwrite/kwrite.cpp

http://commits.kde.org/kate/0852d41175169219925773a4991f58c48a39d8bc