Created attachment 98661 [details]
The file that caused the crash.

Confirmed crash.  Will investigate.

I am not sure where else to ask a question, so I shall ask it here. First of all, let me just say, thank you for making such a great application for linux! :] 

Is it possible to remove all stitches of one colour? I need this particularly because the import feature creates white stitches and I don't see any way to get rid of them, short of manually erasing each one.

Is it possible to add a floss scheme? In Croatia, the most dominant floss is "Ljubica" which has different numbers and colours from all the other 3 schemes in KXStitch. 

Thank you and have a nice day!

The floss schemes are defined in an XML file.  Look at the dmc.xml in the schemes source folder for an example.

You could use that as a template and add flosses to it as needed, perhaps copying and pasting from the other schemes if they match closely.

Removing stitches of one colour can be done either using the replace colour option in the palette view which will change it to another existing colour in the palette or using the colour highlight option and then manually deleting them.

When importing you can use the ignore colour option and select a colour in the picture, e.g. white, which will then not be imported as a stitch.

Regards

Thank you so much!

Apologies for not addressing this sooner, but I believe I have found the cause of the problem.

The names you have assigned to the colours, e.g. 'Light blue', are they stored in the DMC xml file?  If so, can you attach that file here, if not, can you attach the xml file that you did create.

Your pattern uses the DMC scheme, but those colour names don't exist in the official version, consequently when I hover over one of your flosses, there is a search goes on in the background that looks for that colour name, but then doesn't find it in the DMC scheme, resulting in a null pointer dereference and a crash.

Regards

Steve

Created attachment 102609 [details]
Added dmc.xml

Created attachment 102610 [details]
Added the scheme xml file I created

Mmmm, I'm a bit more confused now.
When I open your file, the information in it, is as follows:
Reading version 104
Property: "author" = QVariant(QString, "")
Property: "cellHorizontalGrouping" = QVariant(int, 20)
Property: "cellVerticalGrouping" = QVariant(int, 20)
Property: "clothCountLink" = QVariant(bool, true)
Property: "clothCountUnits" = QVariant(int, 0)
Property: "copyright" = QVariant(QString, "")
Property: "fabric" = QVariant(QString, "")
Property: "fabricColor" = QVariant(QColor, QColor(ARGB 1, 1, 1, 1))
Property: "horizontalClothCount" = QVariant(double, 16)
Property: "instructions" = QVariant(QString, "")
Property: "thickLineColor" = QVariant(QColor, QColor(ARGB 1, 0.501961, 0.501961, 0.501961))
Property: "thinLineColor" = QVariant(QColor, QColor(ARGB 1, 0.752941, 0.752941, 0.752941))
Property: "title" = QVariant(QString, "")
Property: "unitsFormat" = QVariant(int, 0)
Property: "verticalClothCount" = QVariant(double, 16)
QDataStream::operator(DocumentPalette) version 103
m_schemeName "DMC"
m_symbolLibrary "kxstitch"
currentIndex 6
documentPaletteCount 7
key: 0 "Blue" QColor(ARGB 1, 0, 0.47451, 0.796078)
key: 1 "Light blue" QColor(AHSV 1, 0.566667, 1, 1)
key: 2 "Black" QColor(AHSV 1, 0, 0, 0)
key: 3 "Light light gray" QColor(AHSV 1, -1, 0, 0.627451)
key: 4 "Light gray" QColor(AHSV 1, -1, 0, 0.478431)
key: 5 "Dark Gray" QColor(AHSV 1, -1, 0, 0.298039)
key: 6 "Gray" QColor(AHSV 1, -1, 0, 0.388235)

This tells me that the DMC scheme was used, but the colour names (after the key number) do not appear in the DMC scheme.  The other odd thing is that the QColor values are HSV for most of them instead of RGB like the first one.

Neither of the xml files contain those colour names.

Can you step through how you created the new scheme and colours and how you applied that to the pattern you created.

Can you also check in ~/.local/share/kxstitch/schemes to see if there are other xml files there.

Thanks

> Can you step through how you created the new scheme and colours and how you applied that to the pattern you created.

Well it has been some time so I am not sure I can completely replicate it, but I will try. https://goo.gl/photos/AyFYYvLmW5CCgfDDA The crash happens when you hover over the orange square in the Palette in the last photo (after saving, closing and opening the saved file).

> Can you also check in ~/.local/share/kxstitch/schemes to see if there are other xml files there.

From /usr/share/apps/kxstitch/schemes/
> total 180K
> -rw-r--r-- 1 root root  59K Nov 15  2015 anchor.xml
> -rw-r--r-- 1 root root  61K Nov 15  2015 dmc.xml
> -rw-r--r-- 1 root root 2.2K May 10  2016 ljubica.xml
> -rw-r--r-- 1 root root  50K Nov 15  2015 madeira.xml

Found the problem.  After creating a new floss, it was getting added to the scheme, but the scheme wasn't being saved.

Consequently it worked after initially adding it, but when KXStitch was restarted, it wasn't reading the new floss and the pattern couldn't find the colour name.

I can commit a fix to stop it happening again.

To fix any existing files, there are a couple of things you can do.
- manually add the colour names to the dmc scheme again (after the fix is applied)
- convert the pattern to another scheme and back to dmc to correct the colours using the file properties
- create your new scheme, Ljubica, change the pattern scheme to that again using file properties

Regards

Steve

Okay, thanks for such a great app and have a nice day! :]

Git commit 5923153154c2d2448f46f3b8c60d7b75c33e1475 by Steve Allewell.
Committed on 04/12/2016 at 15:42.
Pushed by sallewell into branch 'master'.

Fix for creation of new flosses

The creation of new flosses through the palette manager dialog were
not being saved in the scheme leading to crashes when the patterns were
reloaded.

M  +2    -0    src/NewFlossDlg.cpp

https://commits.kde.org/kxstitch/5923153154c2d2448f46f3b8c60d7b75c33e1475