Bug 362291 - More margins for list items
Summary: More margins for list items
Status: RESOLVED INTENTIONAL
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 10:00 UTC by Alex L
Modified: 2016-07-19 10:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
More margins for list items (83.56 KB, image/png)
2016-04-26 10:00 UTC, Alex L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex L 2016-04-26 10:00:15 UTC
Created attachment 98611 [details]
More margins for list items

See the attached image (left: current look, right: proposed).
The list items are too small, it's hard to interact with them (both tapping and drag them by the handles on the right side of each item).
Suggested changes:
1) more margins between list items and right/left border (the margins should be the same at right and left, symmetrical);
2) more margins between the list items (top and bottom)
for an idea of how much to increase margins, look at the attached image.
Comment 1 Marco Martin 2016-04-27 15:26:05 UTC
Git commit 0378ab2d0cf807484bcb86a21ec8f6ce0f363cc1 by Marco Martin.
Committed on 27/04/2016 at 15:24.
Pushed by mart into branch 'master'.

same height for AbstractListItem and SwipeListItem

calculate the height of AbstractListItem and SwipeListItem
in the exact same way. it may still need some adjustment but
we are sure they will be consisten one to each other

M  +2    -2    examples/gallery/contents/ui/MainPage.qml
M  +1    -1    src/qml/AbstractListItem.qml
M  +2    -1    src/qml/BasicListItem.qml
M  +2    -2    src/qml/GlobalDrawer.qml
M  +1    -4    src/qml/SwipeListItem.qml

http://commits.kde.org/kirigami/0378ab2d0cf807484bcb86a21ec8f6ce0f363cc1
Comment 2 Thomas Pfeiffer 2016-07-19 10:05:17 UTC
I don't think the current height is a problem. We can reopen this if we get complaints from users.