Bug 362258 - regression: drop file in composer no longer adds attachment or asks what to do
Summary: regression: drop file in composer no longer adds attachment or asks what to do
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: composer (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-25 16:58 UTC by Martin Koller
Modified: 2016-08-23 11:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.3.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Koller 2016-04-25 16:58:49 UTC
kmail 5.2.0
KDE Frameworks 5.21.0
Qt 5.6.0 (built against 5.6.0)
The xcb windowing system

When drag&drop a file from konqueror (from $HOME) into a plain text kmail composer window,
kmail2 (Qt4 based) showed a popup menu asking if I want to insert the URL as text or if I want
to attach the file to the mail.

This no longer works in kmail2 (Qt5 based) when I drag&drop from konqueror or from my own Qt5 based application.
In these cases, kmail just inserts always the URL as text.
However it works differently when I drag a file from dolphin, where I still get no popup but kmail just
attaches the file.

Reproducible: Always



Expected Results:  
Show the popup as in Qt4-based kmail and ask me what to do
Comment 1 Laurent Montel 2016-04-26 05:12:17 UTC
konqueror and dolphin uses same component to display file.
I tested here and it attachs directly file.
it's a konqueror kf5 ?
Comment 2 Martin Koller 2016-04-26 06:09:26 UTC
It's konqueror from the openSuse package konqueror-16.04.0-1.7.x86_64
And what I see is that it's still the Qt4 based one ...

ok, now we see a difference here, but I also have the same problem with my own Qt5 based app.

What did change ?
Does kmail now act on a different mime type ?
Why don't I get the popup any more ?
Comment 3 Metko 2016-07-25 08:19:53 UTC
Same here - trying to attach a file to an email by drag&drop or copy/paste from dolphin or konqueror inserts the URI instead of the file. Very annoying. OpenLeap 42.1 , kmail 15.12.3,
Comment 4 Vaibhav 2016-08-23 09:20:29 UTC
Same here.

Using Kmail 5.1.3 on Ubuntu 16.04 LTS.

When adding and attachment using drag and drop, it creates a ling file:///

Although using attachment button (one with paper clip icon) works fine.

Is there any update in which this has been fixed??
Comment 5 Laurent Montel 2016-08-23 11:25:00 UTC
Git commit 7d1047b34354388fbf4343453ddc59e4ba0b0155 by Montel Laurent.
Committed on 23/08/2016 at 11:24.
Pushed by mlaurent into branch 'Applications/16.08'.

Fix Bug 362258 - regression: drop file in composer no longer adds attachment or asks what to do

FIXED-IN: 5.3.1

M  +49   -52   kmail/src/editor/kmcomposerwin.cpp

http://commits.kde.org/kdepim/7d1047b34354388fbf4343453ddc59e4ba0b0155