Bug 362253 - git master: deleting bottommost video track leaves next higher track with opaque/transparent button
Summary: git master: deleting bottommost video track leaves next higher track with opa...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: 16.04.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-25 16:01 UTC by Wegwerf
Modified: 2016-06-07 21:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-04-25 16:01:06 UTC
When deleting the bottommost video track, Kdenlive does not correctly remove the opaque/transparent button of the next higher track that now has become the bottommost video track.

Reproducible: Always

Steps to Reproduce:
1. Start Kdenlive; make sure you have several video tracks>=3.
2. Select "Delete Track" on bottommost video track.

Actual Results:  
New bottommost video track still has opaque/transparent track header button.

Expected Results:  
New bottommost video track must not have an opaque/transparent track header button anymore.
Comment 1 Jean-Baptiste Mardelle 2016-05-06 15:39:58 UTC
Git commit 66e9596b1d5ac67c472c565ca9b8f3086138c2d3 by Jean-Baptiste Mardelle.
Committed on 06/05/2016 at 15:39.
Pushed by mardelle into branch 'Applications/16.04'.

Correctly add/remove last video track compositing on add/remove track

M  +12   -65   src/renderer.cpp
M  +1    -1    src/renderer.h
M  +3    -1    src/timeline/customtrackview.cpp
M  +2    -2    src/timeline/timeline.h
M  +7    -0    src/timeline/transitionhandler.cpp

http://commits.kde.org/kdenlive/66e9596b1d5ac67c472c565ca9b8f3086138c2d3
Comment 2 Wegwerf 2016-05-09 16:47:34 UTC
Jean-Baptiste, thank you very much, that fixes this glitch. I also tried deleting video tracks until there was only one left and it was correctly disabled.

But ... I've found another one this way: after deleting the last video track and then adding a new video track, you end up with the opaque/transparent button again... :)
Comment 3 Jean-Baptiste Mardelle 2016-05-09 21:07:06 UTC
I cannot reproduce what you describe in your last comment. Can you tell me exactly which track you delete and at which position (above or below which one) you insert a new track to reproduce the problem?
Comment 4 Wegwerf 2016-05-10 17:00:16 UTC
That's one way I arrived at the transparent single video track:
1. start new Kdenlive project, with, say 3 video tracks and 2 audio tracks.
2. track header -> right click -> Configure Tracks
3. in the Configure Tracks dialog, mark all video tracks for deletion; press OK.
4. track header Audio 1 -> right click -> Insert Track
5. in Insert Track dialog: insert video track *above* Audio 1; press OK.
You should now end up with the topmost video track being a video track and with the "composite" button being enabled and set to transparent.

By the way: you should also notice that in the Configure Tracks if you now open it as step 6 that the composite check button is always enabled for the lowest video track.
Comment 5 Jean-Baptiste Mardelle 2016-05-10 19:56:54 UTC
Git commit 275ac28e053859e51d0e4362da880182cdb12fe7 by Jean-Baptiste Mardelle.
Committed on 10/05/2016 at 19:56.
Pushed by mardelle into branch 'master'.

Fix incorrect composite transitions after insert/remove track

M  +4    -3    src/timeline/timeline.cpp
M  +1    -1    src/timeline/timeline.h

http://commits.kde.org/kdenlive/275ac28e053859e51d0e4362da880182cdb12fe7
Comment 6 Wegwerf 2016-05-13 15:41:28 UTC
Thank you very much Jean-Baptiste! This is now fixed, so I close this bug report as RESOLVED FIXED.
Comment 7 Vincent PINON 2016-06-07 21:30:03 UTC
Git commit 4053b68169290ba003b73e6f4d808f84b7d83d75 by Vincent Pinon, on behalf of Jean-Baptiste Mardelle.
Committed on 07/06/2016 at 20:11.
Pushed by vpinon into branch 'Applications/16.04'.

Fix incorrect composite transitions after insert/remove track

M  +4    -3    src/timeline/timeline.cpp
M  +1    -1    src/timeline/timeline.h

http://commits.kde.org/kdenlive/4053b68169290ba003b73e6f4d808f84b7d83d75