Bug 361983 - building KNSBackend writes files to source directory
Summary: building KNSBackend writes files to source directory
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: 5.6.3
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-20 00:28 UTC by Carlo Vanini
Modified: 2016-04-20 11:22 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/discover/05800d8b6be2826d29a26e7f832235df9557d5ed
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Carlo Vanini 2016-04-20 00:28:00 UTC 
When building libdiscover (KNSBackend in particular) the files ${backend}.desktop and ${backend}-categories.xml are overwritten inside the source directory.

Is there a reason to keep these files in git, although they are generated?

I found out because cmake complained:
Error renaming from "/scratch/discover-build/libdiscover/backends/KNSBackend/knscomic-backend.desktop" to "/home/carlo/discover/libdiscover/backends/KNSBackend/knscomic-backend.desktop": Invalid cross-device link
/home and /scratch have different muont points, and rename works only on the same volume.

If this behavior must be maintained, consider using
cmake -E copy
instead of
cmake -E rename
in libdiscover/backends/KNSBackend/CMakeLists.txt which works across different volumes.

Reproducible: Always

Steps to Reproduce:
1. cmake
2. make
Comment 1 Aleix Pol 2016-04-20 11:22:39 UTC 
Git commit 05800d8b6be2826d29a26e7f832235df9557d5ed by Aleix Pol.
Committed on 20/04/2016 at 11:21.
Pushed by apol into branch 'master'.

Don't move files while building

Breaks with special set ups

M  +2    -2    libdiscover/backends/KNSBackend/CMakeLists.txt

http://commits.kde.org/discover/05800d8b6be2826d29a26e7f832235df9557d5ed