Bug 361964 - No build support for recreating umbrello icons available
Summary: No build support for recreating umbrello icons available
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other All
: NOR wishlist
Target Milestone: 2.26 (KDE Applications 18.08)
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-19 13:52 UTC by Ralf Habacker
Modified: 2019-11-23 13:55 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 2.25.80 (KDE Applications 18.07.80)
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2016-04-19 13:52:00 UTC
Umbrello sources should have support in the build system for recreating bitmaps from related svg sources. With such a support available, no bitmaps need to be in the umbrello sources anymore because they could be regenerated from svg sources. 

Also the cursor bitmaps, which are a combination of a cursor template and regular umbrello icons could be generated at build time.

Reproducible: Always

Steps to Reproduce:
1. checkout umbrello source
2. inspect cmake files 


Actual Results:  
There is no target to recreate the bitmaps

Expected Results:  
The build system should have a target for recreating the bitmaps
Comment 1 Ralf Habacker 2016-04-20 06:29:42 UTC
Git commit 19f8bf61a979f2726980c4ef8f082d90147addd3 by Ralf Habacker.
Committed on 20/04/2016 at 06:28.
Pushed by habacker into branch 'master'.

Add cmake build support for recreating icons and cursors.

If enabled with cmake command line option BUILD_ICONS and/or BUILD_CURSOR_ICONS
icons and cursor bitmaps are rendered from svg sources by a qt helper
application named svg2png automatically on building umbrello.

Cursor bitmaps are combination of a cursor template svg file and regular
umbrello icons. The cursor template svg file is added by this patch too.

For debugging purpose the additional cmake variable BUILD_ICONS_INTO_SIZE_RELATED_DIRS
is available.

Signed-off-by: Ralf Habacker <ralf.habacker@freenet.de>

M  +0    -1    .gitignore
M  +13   -2    CMakeLists.txt
A  +71   -0    cmake/modules/Macros.cmake
A  +7    -0    maintainer/CMakeLists.txt
A  +102  -0    maintainer/svg2png.cpp     [License: GPL (v2+)]
M  +2    -1    umbrello/CMakeLists.txt
M  +219  -51   umbrello/pics/CMakeLists.txt
A  +482  -0    umbrello/pics/sources/cursor-template.svg

http://commits.kde.org/umbrello/19f8bf61a979f2726980c4ef8f082d90147addd3
Comment 2 Ralf Habacker 2016-04-20 07:20:18 UTC
Git commit 59ef870f4490174473ee1efc172e145500dbb05b by Ralf Habacker.
Committed on 20/04/2016 at 07:19.
Pushed by habacker into branch 'master'.

Fix broken icon install.

M  +159  -53   umbrello/pics/CMakeLists.txt

http://commits.kde.org/umbrello/59ef870f4490174473ee1efc172e145500dbb05b
Comment 3 Ralf Habacker 2016-04-20 09:56:26 UTC
Git commit 1a45ab3b9d2dd0acf20c6df1787f3ddd00417fb6 by Ralf Habacker.
Committed on 20/04/2016 at 09:56.
Pushed by habacker into branch 'master'.

Cleanup icon lists.

Split icon list into regular and cursor icons and install them separatly.

M  +86   -235  umbrello/pics/CMakeLists.txt

http://commits.kde.org/umbrello/1a45ab3b9d2dd0acf20c6df1787f3ddd00417fb6
Comment 4 Ralf Habacker 2016-04-20 10:21:22 UTC
Git commit 616ed80907955deaccebc7ddb27e9166848637e9 by Ralf Habacker.
Committed on 20/04/2016 at 10:20.
Pushed by habacker into branch 'master'.

Disable installing of missing icons.

M  +13   -13   umbrello/pics/CMakeLists.txt

http://commits.kde.org/umbrello/616ed80907955deaccebc7ddb27e9166848637e9
Comment 5 Ralf Habacker 2018-06-11 21:17:29 UTC
Git commit 1490627148eccdb685842b849f95e20c74c623d5 by Ralf Habacker.
Committed on 11/06/2018 at 21:09.
Pushed by habacker into branch 'master'.

Merge branch '361964-recreate-icons'

Fix size, color gradient, text display and backgrounds in svg files and
recreate all png's from svg files.
FIXED-IN:2.25.80 (KDE Applications 18.07.80)


https://commits.kde.org/umbrello/1490627148eccdb685842b849f95e20c74c623d5