Bug 361899 - git 16.04: text shadow in title clips gets clipped
Summary: git 16.04: text shadow in title clips gets clipped
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-17 15:19 UTC by Wegwerf
Modified: 2016-04-26 15:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
example Kdenlive project exhibiting the shadow crop bug (9.47 KB, application/xml)
2016-04-17 15:20 UTC, Wegwerf
Details
screenshot of title with shadow crop bug (167.71 KB, image/jpeg)
2016-04-17 15:23 UTC, Wegwerf
Details
screenshot of project monitor with rendered title clip: shadow clipping to the left of the top bar of the letter "T" (42.55 KB, image/jpeg)
2016-04-17 15:29 UTC, Wegwerf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-04-17 15:19:38 UTC
With the recent version of Kdenlive and MLT when using text shadows the new, larger bounding box is calculated incorrectly, not taking the shadow extend fully correctly into account. This effect becomes most prominent when using a shadow with a negative X axis offset. In addition, this also leads to the text getting cropped at its right border. Please see the attached example project as well as screenshot.

Reproducible: Always

Steps to Reproduce:
1. Open attached Kdenlive project (that consists only of a single title clip with large text and a shadow offset to the left)
2. Open the title clip in the title editor.
3. Zoom to 100%

Actual Results:  
The shadow to the left of the text has been cropped. In addition, the right of the text (the "t") has been cropped too.

Expected Results:  
Shadow correctly shown in all dimensions; no cropping of the text regardless of the shadow offset values chosen.
Comment 1 Wegwerf 2016-04-17 15:20:20 UTC
Created attachment 98425 [details]
example Kdenlive project exhibiting the shadow crop bug
Comment 2 Wegwerf 2016-04-17 15:23:07 UTC
Created attachment 98426 [details]
screenshot of title with shadow crop bug

Please note that the shadow is offset to the left; however, the shadow to the left of the top bar of the "T" is cut off, as is part of the final "t".
Comment 3 Wegwerf 2016-04-17 15:28:33 UTC
Please note that the clipping not only happens in the title editor, but also in the normal rendering of this title clip; albeit to a lesser extend, but still visible. Please see the attached second screenshot: it shows the title clip magnified in the project monitor. When you check the shadow at the left end of the top bar of the "T" you'll notice that the shadow isn't smooth but slightly cropped. In contrast, other regions properly show a smooth shadow.
Comment 4 Wegwerf 2016-04-17 15:29:50 UTC
Created attachment 98427 [details]
screenshot of project monitor with rendered title clip: shadow clipping to the left of the top bar of the letter "T"
Comment 5 Jean-Baptiste Mardelle 2016-04-20 08:21:50 UTC
I just fixed the rendering issue in MLT's git. Preview in titler still has to be fixed.
Comment 6 Jean-Baptiste Mardelle 2016-04-21 22:39:02 UTC
Git commit 4584c15a5d9017d1797955acf6497be0df1e068c by Jean-Baptiste Mardelle.
Committed on 21/04/2016 at 22:38.
Pushed by mardelle into branch 'Applications/16.04'.

Titler: fix shadows clipped and cannot desactivate text editing

M  +59   -18   src/effectstack/graphicsscenerectmove.cpp
M  +18   -3    src/effectstack/graphicsscenerectmove.h

http://commits.kde.org/kdenlive/4584c15a5d9017d1797955acf6497be0df1e068c
Comment 7 Wegwerf 2016-04-26 15:46:32 UTC
This is fixed now, thank you very much Jean-Baptiste! Setting this to RESOLVED FIXED.