Bug 361822 - git master: resetting effect does not work for bin effects
Summary: git master: resetting effect does not work for bin effects
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-15 17:06 UTC by Wegwerf
Modified: 2016-07-22 19:42 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-04-15 17:06:39 UTC 
Resetting the parameters of a bin effect (using the hamburger menu of the effect) does not reset the parameters to their default settings.

Reproducible: Always

Steps to Reproduce:
1. Create a Kdenlive project, such as FullHD 25fps.
2. Add a clip to the project bin.
3. Add an effect to the clip in the project bin, such as Lift/Gamma/Gain.
4. Change the effect parameters
5. Chose "Reset Effect" from the effect's Hamburger menu.

Actual Results:  
Effect parameters don't get reset to their defaults.

Expected Results:  
Effect parameters should be reset to their defaults.
Comment 1 Jean-Baptiste Mardelle 2016-07-22 18:03:14 UTC 
Git commit f23e07f981953be5ecffbbffc1f1f02749e98e36 by Jean-Baptiste Mardelle.
Committed on 22/07/2016 at 18:03.
Pushed by mardelle into branch 'Applications/16.08'.

Fix reset effect in clip bin

M  +4    -1    src/effectstack/effectstackview2.cpp
M  +11   -0    src/mltcontroller/clipcontroller.cpp
M  +1    -0    src/mltcontroller/clipcontroller.h

http://commits.kde.org/kdenlive/f23e07f981953be5ecffbbffc1f1f02749e98e36
Comment 2 Wegwerf 2016-07-22 19:36:32 UTC 
Jean-Baptiste, can you please integrate this fix with master? I'm on master and the bug doesn't seem to be fixed there.
Comment 3 Wegwerf 2016-07-22 19:42:13 UTC 
Now checked on Applications/16.08 and the bug is fixed for me too. Thank you very much for fixing this bug! This avoids another stumbling block to newcomers to Kdenlive.