Bug 361819 - git master: changing bin effect parameters does not mark project as changed
Summary: git master: changing bin effect parameters does not mark project as changed
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-15 15:48 UTC by Wegwerf
Modified: 2016-09-02 20:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-04-15 15:48:34 UTC
When changing the parameters of a bin effect the project does not get marked as changed and the Save button does not get enabled. The project thus cannot be saved using ^S or File>Save until another change is made that correctly sets the project as "dirty".

Reproducible: Always

Steps to Reproduce:
1. Start new project, such as FullHD 25fps.
2. Add clip to project bin.
3. Add effect, such as Bézier Curves to the clip in the project bin.
4. Save project.
5. Edit Bézier Curves effect of project bin clip.

Actual Results:  
Albeit parameters have been changed, the project has not been marked as changed; Save button doesn't get enabled.

Expected Results:  
Project should be marked as changed so that the Save button gets enabled.
Comment 1 farid 2016-08-10 14:42:34 UTC
I can reproduce with today's build.
Comment 2 Jean-Baptiste Mardelle 2016-09-02 19:26:38 UTC
Git commit b2e1bc19f7a2e6c01be83c3f952f998a6fcf01be by Jean-Baptiste Mardelle.
Committed on 02/09/2016 at 19:26.
Pushed by mardelle into branch 'Applications/16.08'.

Integrate master effect update and state change in undo system

M  +35   -0    src/bin/bin.cpp
M  +5    -0    src/bin/bin.h
M  +49   -0    src/bin/bincommands.cpp
M  +29   -0    src/bin/bincommands.h
M  +8    -0    src/bin/projectclip.cpp
M  +1    -0    src/bin/projectclip.h
M  +4    -8    src/effectstack/effectstackview2.cpp
M  +3    -0    src/effectstack/effectstackview2.h
M  +2    -0    src/mainwindow.cpp

http://commits.kde.org/kdenlive/b2e1bc19f7a2e6c01be83c3f952f998a6fcf01be
Comment 3 Wegwerf 2016-09-02 20:16:58 UTC
This is an important fix! Jean-Baptiste, thank you very much for squashing this one that can bite unexpecting users rather badly.