Bug 361766 - Brush editor context menus don't work
Summary: Brush editor context menus don't work
Status: RESOLVED UPSTREAM
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 3.0 Alpha
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-14 14:00 UTC by arualle91
Modified: 2016-10-22 15:00 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description arualle91 2016-04-14 14:00:35 UTC
The context menus of the brush settings editor don't work, so it's impossible to undock it, hide the preset strip/scratchpad and lock the settings.

Reproducible: Always

Steps to Reproduce:
1. Open Brush Settings Editor
2. Right click on editor to open the context menu
3. Click on an option on the menu (for instance, detach from toolbar)



Windows 7
Comment 1 Halla Rempt 2016-04-14 14:06:40 UTC
Hi!

Thanks for your report -- well spotted! I can confirm the bug.
Comment 2 Halla Rempt 2016-04-14 18:25:38 UTC
Meh, and I tested it with an older version of Qt, and there it works: it's a bug in Qt 5.5 and 5.6.
Comment 3 David REVOY 2016-06-09 00:59:37 UTC
Yes, I confirm I'm affected also by this one on 'buntu 16.04 with the patchy version of Qt5.5 installed by default by Canonical/Debian.

I understand the 'resolved upstream' tag to this bug , because I guess new builds will solve it for Windows users. 

I didn't found any PPA workaround to update Qt on 16.04... It's a pretty bad sign if all the derivatives of Ubuntu will be affected by similar issue for the next two years ( Linux Mint, Elementary and all based on LTS ). I hope at one point they'll move to Qt 5.6.1
Comment 4 Halla Rempt 2016-06-09 06:03:07 UTC
I am not even sure it will work with 5.6.1; I have for now disabled the menus, but I'll check after updating all my dependencies for the master branch.
Comment 5 Scott Petrovic 2016-10-21 02:23:19 UTC
I might have a fix for this that is in my brush-editor-ui branch. The issue had to do with the brush editor losing focus and going behind the main window. I am not sure what different behaviors are happening in different distros, but my fix appears to be working in Ubuntu 16.04.

I additionally removed these options out of the right-click menu and put in the bottom left. I think these are pretty important functions, so maybe they don't need to be behind right-click options.  If someone jumps on my branch, then can confirm if the issue is fixed.
Comment 6 David REVOY 2016-10-21 15:40:42 UTC
Tested on XFCE desktop:
- The detach button works:  http://www.peppercarrot.com/extras/temp/2016-10-21_Selection_003.jpg
-  An issue exist to attach it back ( decorated windows )  http://www.peppercarrot.com/extras/temp/2016-10-21_Selection_004.jpg
Comment 7 Scott Petrovic 2016-10-21 21:16:36 UTC
That is odd why the brush selector is not appearing in the brush editor. I am not sure if you need to do a clean build for everything to work right. I added a new UI file and renamed an important class. 

 I remember talking with david a bit on IRC about this. I can't remember, but I thought he did something with his configuration. The brush editor doesn't look right in general, regardless of the attach behavior he is describing.
Comment 8 David REVOY 2016-10-22 08:18:45 UTC
@Scott : In Krita 2.9 series, the right click on the brush-editor dialog -if I remember- was also able to hide/show this top carousel of brush-preset. So I did it to get a more compact layout.
I still have the same preferences from 2.9 to 3.0 ( something rare, because the path changed, and a lot of user had to start all settings from scratch ). So, I inherited this option.
As the right-click on brush-editor dialog is not existing on 3.0, I never knew how to get them back, but the GUI still remember this option and hide the brush carousel.
Comment 9 Scott Petrovic 2016-10-22 15:00:26 UTC
hey @David... Ahh that makes sense.  For now I removed the loading of that option, so hopefully it won't confuse anyone else.

We do need to put a lot of our minds together and try to figure out a more compact and flexible UI for the brush editor. What I did in my branch makes it a bit easier to use with finding and seeing what brush you are on, but the editor settings portion still takes up way too much space for a lot of people.

Based off some ideas that I have seen from other people like Tokiedian, we are probably going to have to adopt some scrollable areas somewhere. The other areas that will be tricky are  the brush engine checkbox settings, and the pen checkbox settings. Probably should discuss this more outside of this bug ticket though...