Bug 361757 - Archive view should not show the horizontal header when aborting opening a corrupt archive
Summary: Archive view should not show the horizontal header when aborting opening a co...
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: 15.12.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Elvis Angelaccio
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2016-04-14 09:15 UTC by Elvis Angelaccio
Modified: 2016-07-05 19:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 16.04.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elvis Angelaccio 2016-04-14 09:15:11 UTC
Steps to reproduce:

Reproducible: Always

Steps to Reproduce:
1. Open a corrupt archive
2. Ark will ask you what to do with the archive
3. Abort opening

Actual Results:  
The archive view shows the horizontal header.

Expected Results:  
The archive view should be empty, with no header.
Comment 1 Elvis Angelaccio 2016-07-05 19:12:24 UTC
Git commit 97eb1b3598dcc684c3cc7ec410b8a2e85cf551c8 by Elvis Angelaccio.
Committed on 05/07/2016 at 19:10.
Pushed by elvisangelaccio into branch 'Applications/16.04'.

archivemodel: check for ListJob errors

If a ListJob ends up with an error (e.g. job aborted due to corrupted archive),
we should not add the listed entries in the model.
FIXED-IN: 16.04.3

Differential Revision: D2082

M  +11   -9    part/archivemodel.cpp

http://commits.kde.org/ark/97eb1b3598dcc684c3cc7ec410b8a2e85cf551c8