361723 – kdf in kf5 does not show all mounted compared to kdf in kde4

Bug 361723 - kdf in kf5 does not show all mounted compared to kdf in kde4

Summary: kdf in kf5 does not show all mounted compared to kdf in kde4

Status:	ASSIGNED

Alias:	None

Product:	kdf
Classification:	Applications
Component:	general (show other bugs)
Version:	unspecified
Platform:	Other Linux

Importance:	NOR normal
Target Milestone:	---
Assignee:	Yoann Laissus

URL:
Keywords:

Depends on:
Blocks:

Reported:	2016-04-13 14:18 UTC by Burkhard Lück
Modified:	2017-03-23 22:35 UTC (History)
CC List:	1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
kdf/kf5 (21.21 KB, image/png) 2016-04-13 14:18 UTC, Burkhard Lück	Details
kdf/kde4 (38.83 KB, image/png) 2016-04-13 14:19 UTC, Burkhard Lück	Details
output of df -h with sdc1 + lexar unmounted (31.79 KB, image/png) 2016-05-14 05:57 UTC, Burkhard Lück	Details
output of df -h with sdc1 + lexar mounted (31.79 KB, image/png) 2016-05-14 05:59 UTC, Burkhard Lück	Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description Burkhard Lück 2016-04-13 14:18:30 UTC

Created attachment 98376 [details]
kdf/kf5

kdf/kf5 does show less devices than kdf/kde4, see screenshots

kdf/kde4:
Ubuntu 15.10 Wiley Qt: 4.8.6 KDE: 4.14.13 KDiskFree: v0.15

kdf/kf5:
master build from sources kdf 16.07.70 frameworks 5.21.0 Qt-5.5.1

The devices are mounted via dolphin panel (disks) respectivly device notifier (usb stick)

$ cat /etc/fstab 
# /etc/fstab: static file system information.
#
# Use 'blkid -o value -s UUID' to print the universally unique identifier
# for a device; this may be used with UUID= as a more robust way to name
# devices that works even if disks are added and removed. See fstab(5).
#
# <file system> <mount point>   <type>  <options>       <dump>  <pass>
proc            /proc           proc    defaults        0       0
# / was on /dev/sda1 during installation
UUID=7b568717-ae68-45fb-bc17-3cac79aaf648 /               ext4    errors=remount-ro 0       1
UUID=ccc93446-f8fd-4223-aec3-2c57846eddf5 none            swap    sw              0       0
/dev/scd0       /media/cdrom0   udf,iso9660 user,noauto,exec,utf8 0       0

$ ls -l /dev/disk/by-uuid
insgesamt 0
lrwxrwxrwx 1 root root 10 Apr 13 16:03 0A1D-9EB9 -> ../../sdd1
lrwxrwxrwx 1 root root 10 Apr 10 14:23 613d5b66-274a-4c75-a706-2c3c67c6c825 -> ../../sdc1
lrwxrwxrwx 1 root root 10 Apr 10 14:23 7b568717-ae68-45fb-bc17-3cac79aaf648 -> ../../sdb1
lrwxrwxrwx 1 root root 10 Apr 10 14:23 874c2a7e-27d1-457c-aade-993e43dc460d -> ../../sda1
lrwxrwxrwx 1 root root 10 Apr 10 14:23 ccc93446-f8fd-4223-aec3-2c57846eddf5 -> ../../sdb3

Comment 1 Burkhard Lück 2016-04-13 14:19:32 UTC

Created attachment 98377 [details]
kdf/kde4

Comment 2 Burkhard Lück 2016-04-13 14:23:26 UTC

Obviously in kdf/kf5 all devices mounted in /media/user/ are missing

Comment 3 Yoann Laissus 2016-04-14 20:54:31 UTC

Yes, it seems it's only your non fstab devices that doesn't show up.
But I can't manage to reproduce that.

Could you add the output of the following command (with the same mounted devices) :
$ LANG=en_US df -kT

Comment 4 Burkhard Lück 2016-04-15 03:43:39 UTC

$ LANG=en_US df -kT
Dateisystem    Typ       1K-Bl�cke   Benutzt  Verf�gbar Verw% Eingeh�ngt auf
udev           devtmpfs    8157352         0    8157352    0% /dev
tmpfs          tmpfs       1635084    100080    1535004    7% /run
/dev/sdb1      ext4      949791812 681474848  220047304   76% /
tmpfs          tmpfs       8175416       128    8175288    1% /dev/shm
tmpfs          tmpfs          5120         4       5116    1% /run/lock
tmpfs          tmpfs       8175416         0    8175416    0% /sys/fs/cgroup
tmpfs          tmpfs       1635084         0    1635084    0% /run/user/133
tmpfs          tmpfs       1635084        44    1635040    1% /run/user/1000
/dev/sda1      ext4     1442015680 569923160  872076136   40% /media/bb/HGST-1,5TB-sda1
/dev/sdd1      vfat        2006528         0    2006528    0% /media/bb/0A1D-9EB9
/dev/sdc1      ext4     1442015292     71144 1368670908    1% /media/bb/HGST-1,5TB-sdc11

Comment 5 Yoann Laissus 2016-04-21 17:41:52 UTC

Sorry for the delay. 
As I suspected, KDF probably don't parse correctly your df output.
Anyway, parsing data from command outputs isn't reliable at all. I just start to port KDF to use Solid and KIO to get devices and space informations. It should fix all your issues (and a lot of other bug reports).

I'll give you some news in the next days !

Comment 6 Yoann Laissus 2016-05-12 20:27:25 UTC

Could you give this branch a try ?
git://anongit.kde.org/clones/kdf/laissus/kdf-clone.git (solid branch)

I have ported KDF to use Solid and it's not relying on the df command anymore (only its name, though ;)

Comment 7 Burkhard Lück 2016-05-12 20:54:47 UTC

does not build in kf5 for me:

CMake Error at doc/app/CMakeLists.txt:4 (kde4_create_handbook):
  Unknown CMake command "kde4_create_handbook".

Comment 8 Yoann Laissus 2016-05-12 21:10:31 UTC

Are you sure you're on the solid branch and not in master ?
The master of my clone is indeed a bit outdated.

Comment 9 Burkhard Lück 2016-05-13 03:34:10 UTC

Sorry I overlooked "branch solid".

Using your clone I see now all devices like in attachment 98377 [details], but no "proc".

But still one issue left:
unmounted devices show correct Size, Free, Full, Usage
all mounted devices have the numbers for  Size, Free, Full, Usage from "/" device

Comment 10 Yoann Laissus 2016-05-13 15:25:52 UTC

Thanks for your testing.

It's normal for proc to not appear.
Currently, only real and network devices are retrieved from Solid.
Anyway, I'll discuss about that during the patch review.

About your last issue, I cannot reproduce on my different computers.
Can you give me a screenshot and the debug ouput of kdf :
QT_LOGGING_RULES="kdf.*=true" kdf

A "df -h" output would also be nice if it has changed significantly since your previous comments.

Comment 11 Burkhard Lück 2016-05-14 05:57:42 UTC

Created attachment 98953 [details]
output of df -h  with sdc1 + lexar unmounted

Comment 12 Burkhard Lück 2016-05-14 05:59:10 UTC

Created attachment 98955 [details]
output of df -h with sdc1 + lexar mounted

Comment 13 Burkhard Lück 2016-05-14 06:02:26 UTC

$ df -h
Filesystem      Size  Used Avail Use% Mounted on
udev            7,8G     0  7,8G   0% /dev
tmpfs           1,6G   62M  1,5G   4% /run
/dev/sdb1       906G  689G  171G  81% /
tmpfs           7,8G  500K  7,8G   1% /dev/shm
tmpfs           5,0M  4,0K  5,0M   1% /run/lock
tmpfs           7,8G     0  7,8G   0% /sys/fs/cgroup
tmpfs           1,6G     0  1,6G   0% /run/user/133
tmpfs           1,6G   36K  1,6G   1% /run/user/1000

$ QT_LOGGING_RULES="kdf.*=true" kdf
kdf(11027)/kdf.private DiskList::DiskList: 
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 

[sdc1 + lexar mounted]

kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/Lexar"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/Lexar"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/Lexar"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/Lexar"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/Lexar"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings: 
kdf(11027)/kdf.private DiskList::updateDevices: updateDevices
kdf(11027)/kdf.private DiskList::deleteAllDevices: 
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sda1"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/Lexar"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::updateDevices: Device  "/media/bb/HGST-1,5TB-sdc11"  :  "735,0 GiB"  /  "905,8 GiB"
kdf(11027)/kdf.private DiskList::loadSettings:

Comment 14 Yoann Laissus 2016-07-02 11:03:21 UTC

Sorry for the late reply.

According to the given informations, I could not manage to figure out what's exactly the problem.
I suspect the mechanism to retrieve disk space informations though.

Do you have anything special about your disk configuration and mount points ?
Can you check if you have the same problem with the device notifier applet ? (with "all devices" selected in its configuration)
Thanks.

Comment 15 Burkhard Lück 2016-07-05 09:00:42 UTC

Disk configuration + mount points please see attachments

Device notifier applet + dolphin show correct numbers, e.g.

Intenso USB stick (mounted on /) 58,4 GiB free
1 TB SSD (mounted on /) 920,46 GiB / 94,36 GiB free
1,4 TB HD (mounted on /media/bb/HGST-1,5TB-sda1/) 798,76 GiB free
1,4 TB HD (mounted on /media/bb/HGST-1,5TB-sdc1/) 1,3 TiB free

kdf has for all devices the numbers of the SSD mounted on / :
905,6 GiB / 94,3 GiB free

1) why 905,6 in kdf and 920,46 in notifier/ dolphin?
2) for unmounted devices the disk size is correctly shown in kdf