Bug 361668 - Layer thumbnails have all white background and wrongly represents layer content
Summary: Layer thumbnails have all white background and wrongly represents layer content
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: 3.0 Alpha
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-12 13:25 UTC by David REVOY
Modified: 2016-04-14 23:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
[ ^ screenshot of the bug ] (34.73 KB, image/png)
2016-04-12 13:25 UTC, David REVOY
Details
[ ^ proposed mockup ] (10.03 KB, image/png)
2016-04-12 14:48 UTC, David REVOY
Details
[ ^ proposed mockup (light-theme) ] (11.53 KB, image/png)
2016-04-12 15:23 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2016-04-12 13:25:17 UTC
Created attachment 98355 [details]
[ ^ screenshot of the bug ]

Hi, one of the confusing change I saw in 3.0alpha* is the representation of the alpha/transparency in the thumbnails inside the layer stack: they are always full white.  

   On 2.9.x it was transparent, the user could see the color of the theme of the background of the layer-stack ( eg. https://krita.org/wp-content/uploads/2016/02/krita_shiftr_layerselect.gif , no border or white background behind the flowers's thumbnails in layer-stack). 
  Photoshop use another strategy here: to represent a little checkerboard on the preview thumbnail ( eg. http://pe-images.s3.amazonaws.com/basics/layers/new/new-layer-2.gif ).
Also, the thumbnail is always a square, and when it's not, a big large white bottom border is added.  
In the screenshot I attach here, you can see a lot of issue:
*  "Black cat" layer represented with a white background when it's full transparency.
* "White cat" layer being totally invisible due to the white on white rendering.
* "Background" layer with a big white padding on the bottom when it's a full red layer.

* krita 3.0 Alpha (git ba25e96)
Comment 1 wolthera 2016-04-12 14:42:06 UTC
Yeah, we discussed this with dmitry, and he said 'ok, I'll make it a checkerbox'... but I think he forgot.
Comment 2 David REVOY 2016-04-12 14:48:39 UTC
Created attachment 98360 [details]
[ ^ proposed mockup ]

After discution on IRC, here is a proposed mockup in attachment.

What is it?
========
A representation of transparency with a checkerboard pattern using specific size of the pattern ( 2px x 2px square because the thumbnail is tiny ) and specific grey colors ( one grey 50% a bit darker <rgb:132,132,132> , other grey 50% a bit lighter <rgb:177,177,177> ). 

What it tries to solve:
=================
* Improves the visibility of bright content
* Improves the visibility of dark content
* Communicate what area is filled with alpha/transparency
Comment 3 David REVOY 2016-04-12 15:23:21 UTC
Created attachment 98362 [details]
[ ^ proposed mockup (light-theme) ]
Comment 4 Scott Petrovic 2016-04-14 23:53:17 UTC
This fixed is pushed out. I should have added the bug prefix to the commit, but forgot.

Here is the GIT commit hash: 58799d65764082e5bcd2b157c2650b8672c43948