Bug 361531 - Clicking notification popup no longer hides it
Summary: Clicking notification popup no longer hides it
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.6.2
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-08 18:50 UTC by Najjar
Modified: 2016-05-05 20:38 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Najjar 2016-04-08 18:50:07 UTC
Prior to Plasma 5.6, if I'm not wrong, clicking on a notification popup made it disappear (the same action as clicking on the X button in its corner). However, this is no longer possible, and the user has to click X to hide it (or wait for it to autohide).

Why is that the case now? I could understand if the purpose was to prevent accidental hiding if the user was in that area and clicked just as the notification appeared. But now the notifications are persistent and show in the notifications applet (so even if the notification was dismissed by accident, the user can go back and read it)

Reproducible: Always
Comment 1 Marco Martin 2016-04-13 10:54:55 UTC
Git commit 2826b64fe98025446c84f5b2c87a0f3ad3358b75 by Marco Martin.
Committed on 13/04/2016 at 10:54.
Pushed by mart into branch 'master'.

use MouseEventListener to close popup on click

restore plasma 4 behavior on correctly closing the notification
popup when clicking anywhere on it.
only on master as requires recent frameworks to work correctly.

M  +3    -1    applets/notifications/package/contents/ui/NotificationPopup.qml

http://commits.kde.org/plasma-workspace/2826b64fe98025446c84f5b2c87a0f3ad3358b75
Comment 2 Martin Klapetek 2016-04-13 11:37:16 UTC
Now couple things - it was actually never really intended to have close-to-click in Plasma 5 popus for various usability reasons and then since recently the popus have selectable text as a feature. That one must remain working.
Comment 3 Kai Uwe Broulik 2016-05-05 20:38:17 UTC
This commit broke the action buttons, when I just click the action it will not trigger, instead the MEL will eat the event off the button and just close the notification. If I press and hold the button it works.