Bug 361491 - composition and aggregation toolbar icons are incorrect
Summary: composition and aggregation toolbar icons are incorrect
Status: RESOLVED NOT A BUG
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 2.16.0 (KDE Applications 15.04.0)
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Lays Rodrigues
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-07 11:49 UTC by Maxim Egorushkin
Modified: 2016-06-22 06:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot of toolbar (5.32 KB, image/png)
2016-04-28 07:09 UTC, Ralf Habacker
Details
umbrello 2.16.3 screenshot (21.22 KB, image/png)
2016-04-29 08:28 UTC, Ralf Habacker
Details
Inversion of pixmaps (1.94 KB, image/png)
2016-04-29 15:11 UTC, Lays Rodrigues
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Egorushkin 2016-04-07 11:49:42 UTC
In the toolbar it shows a filled diamond for aggregation and empty diamond for composition.

It should be the other way around: filled diamond for composition and empty one for aggregation.

Reproducible: Always

Steps to Reproduce:
1. Start the application.
2. Have a careful look at the toolbar icons and their tooltips.
Comment 1 Lays Rodrigues 2016-04-27 21:54:55 UTC
Yeah, thats true.
Comment 2 Lays Rodrigues 2016-04-27 23:03:39 UTC
Ralf, I have searched in the code where this inversion appears, but I wasn't able to find it. The logic of the worktoolbar.cpp and the png files seems right. 
The pics files are correct.
Comment 3 Ralf Habacker 2016-04-28 07:09:54 UTC
Created attachment 98655 [details]
screenshot of toolbar

In umbrello branch Applications/16.04 it looks okay (see screenshot). May be this bug is a duplicate of a another bug, which solved the issue already. You may inspect git log to find it.
Comment 4 Lays Rodrigues 2016-04-28 12:08:28 UTC
Ok, I will find that and apply to branch Frameworks.
Comment 5 Ralf Habacker 2016-04-29 08:28:23 UTC
Created attachment 98680 [details]
umbrello 2.16.3 screenshot

Cannot reproduce this problem with umbrello 2.16.3. Looks like a positive false
Comment 6 Ralf Habacker 2016-04-29 08:38:21 UTC
(In reply to Ralf Habacker from comment #5)
> Cannot reproduce this problem with umbrello 2.16.3. Looks like a positive false
Same with 2.16.0. If there are icons swapped it could only be a packaging or installation issue on the related distribution. If the problem persists, feel free to reopen this bug with informations, which makes it possible to reproduce the problem.
Comment 7 Lays Rodrigues 2016-04-29 15:11:48 UTC
Created attachment 98689 [details]
Inversion of pixmaps

This bugs appears for me in Umbrello Version 2.19.0 downloaded from repository and the build from branch frameworks.
Comment 8 Ralf Habacker 2016-05-01 07:55:42 UTC
Comment on attachment 98689 [details]
Inversion of pixmaps

You need to find out where this swapping come from. This may include basic KF5 libraries.
Comment 9 Lays Rodrigues 2016-05-01 13:21:55 UTC
I had a look at the code, and the method that loads the pixmaps, but I wasn't able to find it. The logic and the name of the files(folder pics) looks right.
Comment 10 Ralf Habacker 2016-05-02 07:21:35 UTC
(In reply to Lays Rodrigues from comment #9)
> I had a look at the code, and the method that loads the pixmaps, but I
> wasn't able to find it. The logic and the name of the files(folder pics)
> looks right.
You are refering to umbrello code or to whole related KF5 code e.g. libKF5IconThemes5, which provides icon support for KF5 ?  

On opensuse distributions for example you have to install several debug packages e.g. by running 

 sudo zypper install kiconthemes-debugsource kiconthemes-devel-debuginfo   libKF5IconThemes5-debuginfo 

on other distributions the package may be named different.

After that it is possible to debug into KF5 code used by umbrello.
Comment 11 Lays Rodrigues 2016-05-02 13:06:50 UTC
I mean here the third comment that I made. Related to the method that load the pixmaps.
So it can be a lib problem?
Comment 12 Ralf Habacker 2016-05-02 13:12:25 UTC
(In reply to Lays Rodrigues from comment #11)
> I mean here the third comment that I made. Related to the method that load
> the pixmaps.
> So it can be a lib problem?
On a opensuse 13.1system (KDE4 based with kf5 libraries)  I do not have the problem with kf5 frameworks build, on another system with opensuse Leap 42.1 (KF5 based) I have, so I would say it is somehow related with KF5 libraries, but cannot say why and where.
Comment 13 Ralf Habacker 2016-05-02 17:25:03 UTC
(In reply to Ralf Habacker from comment #12)
> on another system with opensuse Leap 42.1 (KF5 based) I have,
> so I would say it is somehow related with KF5 libraries, but cannot say why and where.
> running umbrello from framework-branches returns 

Illegal icon group:  7
Illegal icon group:  7
Illegal icon group:  7
Illegal icon group:  7
Illegal icon group:  7
Overwriting existing old cached entry due to collision.

The last message comes from icon cache, in source kcoreaddons/src/lib/caching/kshareddatacache.cpp:1478
Comment 14 Ralf Habacker 2016-05-02 17:29:47 UTC
(In reply to Ralf Habacker from comment #13)
> Illegal icon group:  7
I remember sawing this warnings in older kdelibs version which may indicate an icon cache issue also for 2.16.0
Comment 15 Ralf Habacker 2016-05-02 20:15:05 UTC
(In reply to Ralf Habacker from comment #12)
> on another system with opensuse Leap 42.1 (KF5 based) I have, so I would say it is somehow related with KF5 libraries, but cannot say why and where.

umbrello5 on opensuse Leap 42.1 uses breeze icons https://build.opensuse.org/package/show/KDE:Frameworks5/breeze5-icons, which contains swapped svg icong. Git source is from https://quickgit.kde.org/?p=breeze-icons.git&a=tree&h=b628eb33870953f30f18b3b464cd1f3be4c793af&hb=9ec402757e62bae12102d8a8851e9e5989e3645a&f=icons%2Factions%2F22
Comment 16 Ralf Habacker 2016-05-02 20:29:21 UTC
(In reply to Ralf Habacker from comment #15)
> (In reply to Ralf Habacker from comment #12)
> > on another system with opensuse Leap 42.1 (KF5 based) I have, so I would say it is somehow related with KF5 libraries, but cannot say why and where.
> 
> umbrello5 on opensuse Leap 42.1 uses breeze icons
> https://build.opensuse.org/package/show/KDE:Frameworks5/breeze5-icons, which
> contains swapped svg icon. Git source is from
> https://quickgit.kde.org/?p=breeze-icons.
> git&a=tree&h=b628eb33870953f30f18b3b464cd1f3be4c793af&hb=9ec402757e62bae12102
> d8a8851e9e5989e3645a&f=icons%2Factions%2F22

The kf5 related variant of the icon swapping bug is not a umbrello bug handled by this bug tracker nor could be fixed at umbrello git repo. A bug report and/or patch need to be filed at https://phabricator.kde.org/project/profile/33/.
Comment 17 Ralf Habacker 2016-05-03 08:05:54 UTC
(In reply to Ralf Habacker from comment #16)
> A bug report and/or patch need to be filed at https://phabricator.kde.org/project/profile/33/.

New bug filed at https://phabricator.kde.org/T2404
Comment 18 Ralf Habacker 2016-05-05 03:03:24 UTC
(In reply to Ralf Habacker from comment #17)
> New bug filed at https://phabricator.kde.org/T2404
@lays: The next step is to checkout the breeze-icons git repo from https://phabricator.kde.org/diffusion/BREEZE/, to edit the related icons and to create a patch at https://phabricator.kde.org/differential/diff/create/