Bug 361389 - Huge Notification Size By Showing Entire EMail Content
Summary: Huge Notification Size By Showing Entire EMail Content
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.6.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
: 361624 361995 366360 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-04-04 21:48 UTC by vindicator
Modified: 2016-09-12 13:02 UTC (History)
10 users (show)

See Also:
Latest Commit: http://commits.kde.org/plasma-workspace/e10be6f3ada28005cad8c19422409f818429c883
Version Fixed In: 5.8.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description vindicator 2016-04-04 21:48:06 UTC 
Indirectly related to KDE-Connect?
I'm assuming it is from the large update I did last night. 5.19.0-1 -> 5.20.0-2

Now whenever I receive an email, the notification pops up exceeding the screen height by showing the entire email.

Reproducible: Always

Steps to Reproduce:
1. Installed KDE Connect on Desktop and Android Device
2. Updated Archlinux
3. Wait for notification

Actual Results:  
Entire email is shown in the notification causing the notification size to exceed the screen height.

Expected Results:  
Limit the height of each notification.
Limit the total height of the notification area to <= screen height.
Comment 1 Marco Martin 2016-04-13 11:13:03 UTC 
related to https://bugs.kde.org/show_bug.cgi?id=361624
Comment 2 Cyril Brosch 2016-04-13 11:16:12 UTC 
*** Bug 361624 has been marked as a duplicate of this bug. ***
Comment 3 vindicator 2016-04-16 02:59:22 UTC 
Another big archlinux update today and it still exists: "upgraded plasma-framework (5.20.0-2 -> 5.21.0-1)"
Comment 4 Martin Klapetek 2016-04-21 02:31:08 UTC 
*** Bug 361995 has been marked as a duplicate of this bug. ***
Comment 5 Martin Klapetek 2016-04-21 02:32:29 UTC 
This is because the notification text item was changed to allow
copy-pasting from it. The new text item however does not support
eliding long text.
Comment 6 Kai Uwe Broulik 2016-08-03 12:38:43 UTC 
*** Bug 366360 has been marked as a duplicate of this bug. ***
Comment 7 Till Schäfer 2016-08-03 12:53:49 UTC 
*** Bug 366360 has been marked as a duplicate of this bug. ***
Comment 8 Till Schäfer 2016-08-03 13:02:02 UTC 
as shown in Bug 366360 this also happens, if you have a lot of folders in kmail and receive an e-mail in each of them. 

An unmentioned problem with this behavior is, that the close button is out of the screen, which is problematic for permanent messages. In this case one can only re-login to get rid of the notification.

-> I would like to see a scrollable message popup in this case with limited message height. A sane maximum message height should also be smaller than the complete screen height, as it blocks other work flows until the message disappears (maybe 1/3 of the screen height or something similar)
Comment 9 Kai Uwe Broulik 2016-08-03 13:09:15 UTC 
Shouldn't the notification disappear automatically after a few seconds? In doubt briefly hover it with the mouse and leave the window again to restart the auto-hide timer.
Comment 10 vindicator 2016-08-03 14:44:02 UTC 
I find that the longer the message box, the greater the delay before it disappears.
It's problematic when I get a notification where the height exceeds the screen height and I can't close it.
Comment 11 Martin Klapetek 2016-08-03 22:18:26 UTC 
> Shouldn't the notification disappear automatically after a few seconds

The timeout is computed from the notification text length iirc.
Comment 12 Kai Uwe Broulik 2016-09-12 13:02:26 UTC 
Git commit e10be6f3ada28005cad8c19422409f818429c883 by Kai Uwe Broulik.
Committed on 12/09/2016 at 13:01.
Pushed by broulik into branch 'master'.

[Notifications] Limit notification size and add scroll bar if needed

This limits the size of the notifications in the popup to 10 lines of text.
The limit was removed when it was changed to a TextEdit so text could be copied from it.
FIXED-IN: 5.8.0

M  +46   -25   applets/notifications/package/contents/ui/NotificationItem.qml
M  +3    -2    applets/notifications/package/contents/ui/NotificationPopup.qml

http://commits.kde.org/plasma-workspace/e10be6f3ada28005cad8c19422409f818429c883