Bug 361357 - git master - issues with new Clip Properties Widget
Summary: git master - issues with new Clip Properties Widget
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-03 19:08 UTC by Unknown
Modified: 2016-04-19 21:23 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2016-04-03 19:08:31 UTC
It looks like in recent git master builds that the Clip Properties in the Project Bin has been made into its own widget, as opposed to a slide-in window in the Project Bin. I think that's a great idea! Much better than a slide-out window that you have to resize or wiggle around the Project Bin. Good stuff.

There are some issues that arise with this change, however. I've listed them and some possible solutions to fixing them:

(1) If the Clip Properties widget has dimensions that are smaller than the content of the widget itself, it still forces the layout to change - whether it's the selected widget or simply in the layout at all - and the layout cannot be adjusted to make the widget smaller or resize any widgets its grouped together with. I'd suggest that the Clip Properties widget can re-size without affecting the rest of the layout, like how all the other widgets behave. (I also reported this issue in Bug 356488 - https://bugs.kde.org/show_bug.cgi?id=356488.)

(2) This new change can create some confusion with the Effect/Transition properties widget, because both have the word "Properties" in it, and now it seems to leave the purpose of the "Properties" widget ambiguous. I don't have an ideal title name for the Properties widget, but even changing it to something like "FX Properties" would be much better, at this point, than just "Properties". Conveniently, left-clicking once on clips or transitions in the Timeline open the Properties window up automatically, anyways, so maybe "FX Properties" wouldn't be such a bad idea. ("FX" Is always had a professional, flashy video editor feel, anyway. :) )

(3) There is no label as to what clip the Clip Properties widget is showing the details FOR. IT doesn't show the clip title/name anywhere, or file name, etc. This issue was made present to me when working with a clip in the timeline that was different from the clip currently displayed/selected/present in the Clip Properties widget. I would suggest putting the clip name (or file name, whichever) in the actual content window of the clip properties widget, or, in parenthesis, have the clip name in the widget header, to the right of the actual "Clip Properties" text. Or both, even, as this would be an issue if the title bars are hidden in the layout.

(4) When double-clicking a clip in the Project Bin or clicking the Pencil icon in the Project bin, the Clip Properties widget disappears, then re-appears with the clip properties data. ... ...eh, not the best behavior for editing workflow, let alone ideal for the user's custom editing layout. SUGGESTED SOLUTION: When the Clip Properties widget is currently in the layout, double-clicking a clip or clicking the "Clip Properties" button DOESN'T remove the widget from the layout, or close the widget. Instead, it brings it to the front (as it does now), showing the details of the chosen clip. So, in other words, cease any options in the Project Bin from making the Clip Properties widget disappear/close/leave the layout.

(5) Being that the "Clip Properties" button at the top of the Project Bin is an enable/disable button, rather than a one-time click button that brings the user to the clip properties widget, , I might suggest changing it to a single-click button that behaves just like double-clicking on a clip in the Project Bin -- mainly for the reasons stated above. I think that any function in the Project Bin that closes/removes the Clip Properties widget is a bad idea, personally.

Thanks for reading guys. :)

Reproducible: Always




Suggested/Bugs discovered while using Kdenlive 16.07.70 git master build via kdenlive-master ppa. Ubuntu 16.04 x64, Unity 7.4.0 desktop environment.
Comment 1 Unknown 2016-04-03 19:11:16 UTC
One last comment regarding issue #5 - if you'd prefer to keep the Clip Properties button in the Project Bin an "enable/disable" button, I might consider changing the tooltip name to "Show Clip Properties" and "Hide Clip Properties", rather than just "Clip Properties". Makes its function a little more understandable from the start.
Comment 2 Jean-Baptiste Mardelle 2016-04-03 20:03:03 UTC
Git commit d062e478643e2cba3a1298e984575ae8cc650513 by Jean-Baptiste Mardelle.
Committed on 03/04/2016 at 20:02.
Pushed by mardelle into branch 'Applications/16.04'.

Make clip properties widget use scrollbar so that size is not changed
Add clip name on top

M  +5    -15   src/bin/bin.cpp
M  +2    -1    src/bin/bin.h
M  +1    -0    src/bin/projectclip.cpp
M  +0    -3    src/mainwindow.cpp
M  +29   -20   src/mltcontroller/clippropertiescontroller.cpp
M  +4    -1    src/mltcontroller/clippropertiescontroller.h

http://commits.kde.org/kdenlive/d062e478643e2cba3a1298e984575ae8cc650513
Comment 3 farid 2016-04-05 18:30:49 UTC
related to this: https://bugs.kde.org/show_bug.cgi?id=356629
Comment 4 Unknown 2016-04-05 20:06:45 UTC
Farid, can you use the latest git master build and test? Now that it uses a scrollbar, the layout doesn't resize when you double-click to open the clip properties widget.
Comment 5 farid 2016-04-05 20:09:56 UTC
fixed.
Comment 6 Unknown 2016-04-11 00:52:41 UTC
Sweet, Farid!

Also, JB, it looks like #4 in the OP was addressed and implemented. Thanks for that! However, there is still an issue: when the Clip Properties widget and the Project Bin widget are grouped together, double-clicking a clip in the Project Bin still makes the Clip Properties widget close/disappear and open/re-appear. When the Clip Properties widget is on its own in the layout or is grouped to a different set of widgets, this issue isn't present.
Comment 7 Jean-Baptiste Mardelle 2016-04-12 07:27:58 UTC
Git commit 81539c5f7a8b9eb2013157040c931b1d8a84f887 by Jean-Baptiste Mardelle.
Committed on 12/04/2016 at 07:27.
Pushed by mardelle into branch 'Applications/16.04'.

Improve layout on first start, fix clip properties behavior

M  +14   -5    src/bin/bin.cpp
M  +2    -0    src/bin/bin.h
M  +18   -4    src/mainwindow.cpp
M  +2    -0    src/mainwindow.h

http://commits.kde.org/kdenlive/81539c5f7a8b9eb2013157040c931b1d8a84f887
Comment 8 Unknown 2016-04-19 21:23:26 UTC
Works just fine now. Thanks JB! Marking this bug as fixed/resolved.