Bug 361325 - shortcut schemes broken again
Summary: shortcut schemes broken again
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: release_blocker
: 361654 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-04-02 16:04 UTC by Raghavendra kamath
Modified: 2016-05-07 01:50 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2016-04-02 16:04:38 UTC
There are some problems and inconsistencies in the shortcut dialog box of krita 3.0 git master
the problems are as follows:

1) The shortcuts which are changed don't get saved or implemented.
2) To work around this I tried to save the changed scheme by pressing save/load button The browse file dialog shows home folder, ( this is not in the resources folder so I doubt it s supposed to get loaded next time I start krita) I browsed to resource folder and saved it .
3) As expected the shortcut scheme I saved didn't get loaded so I pressed load shortcut and then browsed to the place where I saved it , but to my dismay the file dialog doesn't show it , the file type filter is "Shortcuts" and the file that is saved doesn't have any extension.
4) Now in a bid to save my changes I tried by pressing the "new" button in the shortcut dialog it gave me a popup window to input the name for this scheme, I added a name and saved it , the changes were applied. but
5) next time i load krita this new shortcut scheme is not loaded so my changes are again lost

To add to this there is also a crash when we cancel the save and load dialog, I have reported 
that in other bug report here -> https://bugs.kde.org/show_bug.cgi?id=360595

I really wish this bug gets solved and there is some clarity in handling keyboard shortcuts. The concept of custom shortcut scheme is really nice and good , but these bugs hamper the newly implemented system.

Let me know if you need any more details.

P.S. I am marking this major as shortcuts are integral part and right now changing them or doing anything is kind of confusing and buggy, if you guys feel it to be classified as normal you may do so 

thank you



Reproducible: Always
Comment 1 Marcus Kjeldsen 2016-04-10 08:36:45 UTC
I can confirm win win10 alpha1.

(but it is great that shortcut settings are getting an overhaul! Looking forward to the progress)
Comment 2 Raghavendra kamath 2016-04-12 08:17:00 UTC
*** Bug 361654 has been marked as a duplicate of this bug. ***
Comment 3 Raghavendra kamath 2016-04-12 08:19:21 UTC
Comments about this bug as per deevad on other bug reported here

"Hi, I can't assign custom keyboard shortcut while testing 3.0 alpha (git 695cc85).
I'm used to assign 'undo' <Ctrl>Z to only Z , and 'redo' <Ctrl><Shift>Z to Y. 
Same with 'Flatten image' <Ctrl><Shift>E to <Ctrl><Shift>M.

To reproduce: =========== 
* (menu)>Settings>Configure Krita
* (vertical tab)> Keyboard shortcuts>Menu>Edit
* Assign new keyboard shortcut to Undo and Redo
* Press OK on the dialog
* Test

Result: ======

Nothing happen. The old keyboard shortcut are still active. If the user go back to (menu)>Settings>Configure Krita and check (vertical tab)> Keyboard shortcuts>Menu>Edit, nothing changed.

( note: I changed my pref folder ~/.local/share/krita to receive 777 permission to exclude a read/write permission issue. )"
Comment 4 Raghavendra kamath 2016-04-13 05:59:40 UTC
*** Bug 361593 has been marked as a duplicate of this bug. ***
Comment 5 Raghavendra kamath 2016-04-13 06:01:16 UTC
Wolthera mention in other bug report that "Input settings aren't affected, btw."
Comment 6 eliotJ 2016-04-13 11:34:41 UTC
I confirm this bug... Win 7 64 bit.
Comment 7 David REVOY 2016-04-14 19:39:18 UTC
Thanks boud, your commit (pasted under) fixed my bug in comment 3 :-)

Boudewijn Rempt 2016-04-14 07:05:13 UTC
Git commit d84e0ad2bd5ddaf51e2088ac4b6c5f4d6e96699d by Boudewijn Rempt.
Committed on 14/04/2016 at 07:04.
Pushed by rempt into branch 'master'.
Actually save the custom shortcuts
M  +1    -0    libs/ui/dialogs/kis_dlg_preferences.cc
http://commits.kde.org/krita/d84e0ad2bd5ddaf51e2088ac4b6c5f4d6e96699d
Comment 8 Raghavendra kamath 2016-04-15 07:14:02 UTC
The shortcuts are now saved  thanks boud for fixing those

Now the problem is with saving and loading new shortcut schemes. they seem to get saved in /.local/share/krita/shortcuts but they don't show up in the drop-down list.
Comment 9 Halla Rempt 2016-04-16 14:11:24 UTC
https://phabricator.kde.org/T2309
Comment 10 Raghavendra kamath 2016-04-21 06:25:15 UTC
All my problems stated in thsi bug report are fixed 

commit solving file extension for shortcuts->
https://quickgit.kde.org/?p=krita.git&a=commit&h=5bd8323f83f14d2e1e5db8c770b37558392ad52d

shortcuts can now be loaded and the shortcut are retained on restart.

I am closing this bug , if anything crops up we can open a new one as for now all problems seem fixed

thanks Boud and Michael for fixing things :)
Comment 11 ocumo 2016-05-07 01:50:53 UTC
I have just downloaded krita-3.0-Beta-master-37389d5-x86_64.appimage and I have exactly the same problem described by this bug report.  It is not fixed.   I can see that there are a lot of bug reports on this issue, with minor or bigger differences, some are closed, some are in other states.

Please is it possible to make this a bit less confusing?  It doesn't make sense to see so many opened tickets for basically the same thing.

It is not possible to set new shortcuts, overriding the default ones.  Please reopen this bug or indicate what is the correct thread for this.  Thank you!