Bug 360985 - Fifteen Puzzle should switch to FullRepresentation sooner when added to a thick sidebar-style panel
Summary: Fifteen Puzzle should switch to FullRepresentation sooner when added to a thi...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Fifteen Puzzle widget (other bugs)
Version First Reported In: 5.5.3
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-25 22:47 UTC by andreas
Modified: 2025-05-29 22:00 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.4.0
Sentry Crash Report:


Attachments
fifteen puzzle (824.92 KB, image/png)
2016-03-25 22:47 UTC, andreas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas 2016-03-25 22:47:10 UTC
Created attachment 98082 [details]
fifteen puzzle

look a bit strange when you click on the icon mode and the minimum size is to big for the sidebar (should work there)
Comment 1 Bug Janitor Service 2025-05-21 16:48:18 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/821
Comment 2 cwo 2025-05-21 18:24:29 UTC
Git commit c2c8cc2fe058094dcf190f4d063e238b8328e610 by Christoph Wolk.
Committed on 21/05/2025 at 16:44.
Pushed by cwo into branch 'master'.

applets/fifteenpuzzle: reduce switch size

Fifteen Puzzle has a rather large switch size, so if someone puts it
even on a rather chonky panel, they'll get a huge icon. What the user
intended (if they did it intentionally) was likely to get a smallish
playable puzzle, rather than a giant green question mark icon.

Instead, set the switch sizes to 5 gridUnits, which is what we also use
in similar applets like Comic or Media Frame. It's definitely playable
at around that size. We keep the original values as the default sizes,
so adding it to the desktop should result in the same size as before. In
the future we might want to consider reducing the size of the shuffle
button/timer a bit to make them fit that size even for languages with
rather long words but it should be fine for now - I'd say even a
slightly cut-off version is better than the status quo.

M  +5    -2    applets/fifteenPuzzle/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/-/commit/c2c8cc2fe058094dcf190f4d063e238b8328e610
Comment 3 cwo 2025-05-21 18:50:51 UTC
Git commit 7e40f79747d75e181935dd3b9876a3dae22bee58 by Christoph Wolk.
Committed on 21/05/2025 at 18:46.
Pushed by cwo into branch 'Plasma/6.4'.

applets/fifteenpuzzle: reduce switch size

Fifteen Puzzle has a rather large switch size, so if someone puts it
even on a rather chonky panel, they'll get a huge icon. What the user
intended (if they did it intentionally) was likely to get a smallish
playable puzzle, rather than a giant green question mark icon.

Instead, set the switch sizes to 5 gridUnits, which is what we also use
in similar applets like Comic or Media Frame. It's definitely playable
at around that size. We keep the original values as the default sizes,
so adding it to the desktop should result in the same size as before. In
the future we might want to consider reducing the size of the shuffle
button/timer a bit to make them fit that size even for languages with
rather long words but it should be fine for now - I'd say even a
slightly cut-off version is better than the status quo.


(cherry picked from commit c2c8cc2fe058094dcf190f4d063e238b8328e610)

Co-authored-by: Christoph Wolk <cwo.kde@posteo.net>

M  +5    -2    applets/fifteenPuzzle/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/-/commit/7e40f79747d75e181935dd3b9876a3dae22bee58