Bug 360895 - Use the selection color to mark the current active tool in the toolbox
Summary: Use the selection color to mark the current active tool in the toolbox
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 3.0 Alpha
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 11:43 UTC by eliotJ
Modified: 2016-05-24 16:46 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/calligra/a372129071c6e10d01e9ab2164e7b41147466d3a
Version Fixed In:
Sentry Crash Report:

Attachments
My proposal to fix these issue. (187.45 KB, image/png)
2016-03-23 11:45 UTC, eliotJ 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description eliotJ 2016-03-23 11:43:20 UTC 
Currently in Krita 3.0 dev1 Toolbox gives very poor visual feedback of selected tool (too small contrast between selection rectangle over icon and background of Toolbox).

I have tested on Windows 7.

Please check atached image for details :).

Reproducible: Always
Comment 1 eliotJ 2016-03-23 11:45:27 UTC 
Created attachment 98040 [details]
My proposal to fix these issue.
Comment 2 Halla Rempt 2016-03-23 12:57:24 UTC 
Git commit 441a6fa591cc71470712208c36dd3e2937e6afd5 by Boudewijn Rempt.
Committed on 23/03/2016 at 12:53.
Pushed by rempt into branch 'master'.

Use the highlight color for the selected tool

This also 'fixes' the setting of the highlight color in
the toolbar, we should be taking the app's palette, not the
one set on the current widget.

M  +2    -1    libs/ui/kis_paintop_box.cc
M  +2    -0    libs/widgets/KoToolBox.cpp
M  +15   -0    libs/widgets/KoToolBoxButton.cpp
M  +1    -0    libs/widgets/KoToolBoxButton_p.h

http://commits.kde.org/krita/441a6fa591cc71470712208c36dd3e2937e6afd5
Comment 3 Friedrich W. H. Kossebau 2016-05-24 16:46:20 UTC 
Git commit a372129071c6e10d01e9ab2164e7b41147466d3a by Friedrich W. H. Kossebau, on behalf of Boudewijn Rempt.
Committed on 24/05/2016 at 14:18.
Pushed by kossebau into branch 'master'.

Use the highlight color for the selected tool

This also 'fixes' the setting of the highlight color in
the toolbar, we should be taking the app's palette, not the
one set on the current widget.

M  +2    -0    libs/widgets/KoToolBox.cpp
M  +15   -0    libs/widgets/KoToolBoxButton.cpp
M  +1    -0    libs/widgets/KoToolBoxButton_p.h

http://commits.kde.org/calligra/a372129071c6e10d01e9ab2164e7b41147466d3a